Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Bence Béky <notifications@github.com> Wed, 22 July 2020 13:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CF8FE3A09A4 for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 06:13:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dZjr_f1Dv81H for <quic-issues@ietfa.amsl.com>; Wed, 22 Jul 2020 06:13:26 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63C473A09A2 for <quic-issues@ietf.org>; Wed, 22 Jul 2020 06:13:26 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id 2C64752113A for <quic-issues@ietf.org>; Wed, 22 Jul 2020 06:13:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595423605; bh=rqRQfqG4mdCNYhFcJhYxHXZHtaX2zLToSXTcCUw0qQs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Mkf5qD5kgagZTqzoVgQkMngLZop+N+IQji1YaIz1ZYUK1c6swXarCtMEoqqpS4Qx7 kxq6Qh5zu0IDuiIDvkDd3sFeH2gjcmx9KG7GUmLGh13gLzi6GCHVfi8Xm7fq5IQs0g 3tOmQWBP0LfqXvuGqEimGmITkIZkSr3pHDPsF1N4=
Date: Wed, 22 Jul 2020 06:13:25 -0700
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK353E2L4I4FAIAAPFF5EQOHLEVBNHHCPBRDMY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3925/review/453302538@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3925@github.com>
References: <quicwg/base-drafts/pull/3925@github.com>
Subject: Re: [quicwg/base-drafts] Rework flow of Push ID (#3925)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f183b751d1cf_129c3fd5086cd9604258dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OViIvbDOPbtP0Ch2sBWbhpA8jYU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Jul 2020 13:13:28 -0000
@bencebeky commented on this pull request. > + +The Push ID space begins at zero, and ends at a maximum value set by the +MAX_PUSH_ID frame; see {{frame-max-push-id}}. In particular, a server is not +able to push until after the client sends a MAX_PUSH_ID frame. A client sends +additional MAX_PUSH_ID frames to control the number of pushes that a server can +promise. A server SHOULD use Push IDs sequentially, beginning from zero. A +client MUST treat receipt of a push stream with a Push ID that is greater than +the maximum Push ID as a connection error of type H3_ID_ERROR. + +The Push ID is used in one or more PUSH_PROMISE frames ({{frame-push-promise}}) +that carry the header section of the request message. These frames are sent on +the request stream which generated the push. This allows the server push to be +associated with a client request. When the same Push ID is promised on multiple +request streams, the decompressed request field sections MUST contain the same +fields in the same order, and both the name and the value in each field MUST be +exact matches. "same fields" and "both the name and the value in each field MUST be identical" are redundant. How about "MUST contain identical fields in the same order" or "MUST contain fields with identical name and value in the same order"? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3925#discussion_r458780531
- [quicwg/base-drafts] Rework flow of Push ID (#392… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Lucas Pardue
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Martin Thomson
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Bence Béky
- Re: [quicwg/base-drafts] Rework flow of Push ID (… ianswett
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop
- Re: [quicwg/base-drafts] Rework flow of Push ID (… Mike Bishop