Re: [quicwg/base-drafts] First octet changes (#2006)

[erickinnear <[e-mail]>]

erickinnear commented on this pull request.



> +with the remaining bytes.
+
+{{pseudo-hp}} shows a sample algorithm for applying header protection. Removing
+protection only differs in the order in which the packet number length
+(pn_length) is determined.
+
+~~~
+mask = header_protection(hp_key, sample)
+
+pn_length = (packet[0] & 0x03) + 1
+if packet[0] & 0x80 == 0x80:
+   # Long header: 4 bits masked
+   packet[0] ^= mask[0] & 0x0f
+else:
+   # Short header: 5 bits masked
+   packet[0] ^= mask[0] & 0x1f

@ianswett I think you can still tell which connections aren't spinning even if set to a random value. But I agree about leaking information unintentionally. 

I'd also like to make sure we grease this bit, but I would be fine with doing that in a way that doesn't involve encrypting it with the rest of the packet. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2006#discussion_r234030117