Re: [quicwg/base-drafts] Packets on one path must not adjust values for a different path (#3139)

mirjak <notifications@github.com> Fri, 25 October 2019 08:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 69A05120273 for <quic-issues@ietfa.amsl.com>; Fri, 25 Oct 2019 01:43:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LzH7dkHfZ90x for <quic-issues@ietfa.amsl.com>; Fri, 25 Oct 2019 01:43:22 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6AE4B1208CA for <quic-issues@ietf.org>; Fri, 25 Oct 2019 01:43:20 -0700 (PDT)
Received: from github-lowworker-3a0df0f.ac4-iad.github.net (github-lowworker-3a0df0f.ac4-iad.github.net [10.52.25.92]) by smtp.github.com (Postfix) with ESMTP id BA183660916 for <quic-issues@ietf.org>; Fri, 25 Oct 2019 01:43:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571992999; bh=1pyZ6K7uEyyW+nJxzROqWDgkjIYvMDE34OotnWnPBjg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ypcGoBeGBZWi8RQv3AVyZ2MwkbXHUmi0v9vmsQj1OhvMKWRKJVZXja1EyVAmcjupY Vv69PlYUeGsOvOLgXYZhpFFKDtP/7jW2ZxJ18XD2fvPoZoqeI8AGWIcTf867Oy59QW SSRSplhFVwZ9Qif+hAvZAzmPf1YVoMH5ACEdWSmw=
Date: Fri, 25 Oct 2019 01:43:19 -0700
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3HFBXR65XKFCWMV353X73DPEVBNHHB47SZJY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3139/review/307060651@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3139@github.com>
References: <quicwg/base-drafts/pull/3139@github.com>
Subject: Re: [quicwg/base-drafts] Packets on one path must not adjust values for a different path (#3139)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db2b5a7abfaf_7c463fd31becd96047436"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OfzPspF9WlazNygpxK_wWzPNfKU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Oct 2019 08:43:24 -0000

mirjak commented on this pull request.



> @@ -2096,7 +2096,7 @@ more likely to indicate an intentional migration rather than an attack.
 ## Loss Detection and Congestion Control {#migration-cc}
 
 The capacity available on the new path might not be the same as the old path.
-Packets sent on the old path SHOULD NOT contribute to congestion control or RTT
+Packets sent on the old path MUST NOT contribute to congestion control or RTT
 estimation for the new path.
 

Yes, good question. So I think it is correct that it is important to make sure that when you migrate you need to use a new cc context and not just keep using the old one. But I guess this was a SHOULD because using the old estimate as the new initial could make sense e.g. if you have very small RTTs or only a few ms. On the other hand, as Ian said, you should get a new sample with the validation anyway and therefore it should not have an impact. Do we maybe need more text to actually explain that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3139#discussion_r338945759