Re: [quicwg/base-drafts] Replace recovery epoch with congestion event (#2585)
MikkelFJ <notifications@github.com> Wed, 03 April 2019 13:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3695B1205CF for <quic-issues@ietfa.amsl.com>; Wed, 3 Apr 2019 06:13:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d7yilJoB-kPr for <quic-issues@ietfa.amsl.com>; Wed, 3 Apr 2019 06:13:26 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 777B41205B5 for <quic-issues@ietf.org>; Wed, 3 Apr 2019 06:13:26 -0700 (PDT)
Date: Wed, 03 Apr 2019 06:13:25 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554297205; bh=aNt0/kIv9P1jwue+3VIpjGEXzZxuU0Rifsfos5srL6o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iVWcIuEw0NFFzV+QdKwjH/SkIwTG6uv6kj7qxJBjHRHwZt12pBU6vek9q5gbDmIoV Q1S7BNP6uEvoF+5vudANrjOh+3IQh/dCTZNF0VcMnkIJJy2gbgphRTgl1fwB5FRQwA 6pvx7vdnzWbXiTq7FLvVcgcVNd2j8oABxBjCLn2I=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6e3b886d2df33f1f2b48270eb9d249355df6addf92cf0000000118bc737592a169ce198953e0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2585/review/222199444@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2585@github.com>
References: <quicwg/base-drafts/pull/2585@github.com>
Subject: Re: [quicwg/base-drafts] Replace recovery epoch with congestion event (#2585)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca4b1755667f_4ae83f800f4d45bc22214d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Opz495oLDX0sldRNbS95l1ivIWI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2019 13:13:28 -0000
mikkelfj commented on this pull request.
> @@ -1318,8 +1318,8 @@ window.
~~~
CongestionEvent(sent_time):
- // Start a new congestion event if the sent time is larger
- // than the start time of the previous recovery epoch.
+ // Start a new congestion event if packet was sent after the
+ // start of the previous congestion event.
Maybe keep congestion event as the trigger. Isn't the period referred to as the recovery period, if entered.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2585#discussion_r271735047
- [quicwg/base-drafts] Replace recovery epoch with … ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Jana Iyengar
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Jana Iyengar
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… Marten Seemann
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ
- Re: [quicwg/base-drafts] Replace recovery epoch w… ianswett
- Re: [quicwg/base-drafts] Replace recovery epoch w… MikkelFJ