Re: [quicwg/base-drafts] One of 'host' or ':authority' is required (#3475)

David Schinazi <notifications@github.com> Sun, 23 February 2020 00:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9AE343A07F0 for <quic-issues@ietfa.amsl.com>; Sat, 22 Feb 2020 16:33:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JeqGEYVAo_C4 for <quic-issues@ietfa.amsl.com>; Sat, 22 Feb 2020 16:33:29 -0800 (PST)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58E093A07EE for <quic-issues@ietf.org>; Sat, 22 Feb 2020 16:33:29 -0800 (PST)
Date: Sat, 22 Feb 2020 16:33:28 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582418008; bh=zPMsoPCtsbJEgIed0dQ05ZCzjyy0K8mQDtbPqmh+5W0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OTkRc4e2jTp3w0BKDlQXUFdH2yL09GIiORnWjI/DJDkv4qImWW6Ob2dvy9izDAuiP uJUHaU+9igrVXcB/2OqN5clzLEz/KPU/xroQW6AhGyLTNQnMeaolbEl1oIAlWJ6HCF vsoBjrItgKScsyEF2ypY61gUqMIVQcgt0560r2QY=
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZWSIVRINHIT5IDLO54L35NREVBNHHCD3A4PM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3475/review/363058451@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3475@github.com>
References: <quicwg/base-drafts/pull/3475@github.com>
Subject: Re: [quicwg/base-drafts] One of 'host' or ':authority' is required (#3475)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e51c85817222_43da3ffa26ccd96c202078"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/OwFcSMtNU8b8LaNU1oN4rwE0Uoo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Feb 2020 00:33:31 -0000

DavidSchinazi commented on this pull request.



> @@ -554,8 +554,11 @@ The following pseudo-header fields are defined for requests:
 
 All HTTP/3 requests MUST include exactly one value for the ":method", ":scheme",
 and ":path" pseudo-header fields, unless it is a CONNECT request ({{connect}}).
-An HTTP request that omits mandatory pseudo-header fields or contains invalid
-values for those fields is malformed ({{malformed}}).
+If the ":scheme" pseudo-header field identifies a scheme which has a mandatory
+authority component (including "http" and "https"), the request MUST contain
+either an ":authority" pseudo-header field or a "Host" header field; these
+fields MUST NOT be empty. An HTTP request that omits mandatory pseudo-header

I find the wording `; these fields MUST NOT be empty.` to be slightly ambiguous because it just follows a sentence that says that they may be omitted. Perhaps something like `; additionally, if these headers are sent, their values MUST NOT be empty.`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3475#pullrequestreview-363058451