Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)

ianswett <notifications@github.com> Tue, 22 October 2019 04:37 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 03690120058 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:37:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.382
X-Spam-Level:
X-Spam-Status: No, score=-1.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y8WlfKgKc9S6 for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:37:13 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C797912004F for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:37:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=opGe+xtssfS0NVcVIOluoyPQVls=; b=UMDng1yT9BWHQ2Hz UmOH3YA2rxsz82JmhPnweZl8+U4nhS6yGPwVzgbKUP8gnA13g+g9feeaN8iH8fh9 J5rfASBnBmxfFgxH8ikv0bk9CDgFJ/F86zR5FOU8BwpnCX3bDLhklUgniKP6bVlb QytjCc3+M9M/cHxA9KidvnYnHQM=
Received: by filter1750p1mdw1.sendgrid.net with SMTP id filter1750p1mdw1-13477-5DAE77DE-15 2019-10-22 03:30:38.467588067 +0000 UTC m=+355307.390758540
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) by ismtpd0066p1iad1.sendgrid.net (SG) with ESMTP id i73GjzNPRrqP-Xkfs222dA for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:30:38.454 +0000 (UTC)
Date: Tue, 22 Oct 2019 03:30:38 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYV54JVYMXMII6CXTN3XO4GTEVBNHHB4RTQYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3098/review/304950229@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3098@github.com>
References: <quicwg/base-drafts/pull/3098@github.com>
Subject: Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae77d93bd44_4d653f87e6ccd9601109db"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3NNUWjFX4j1FnWCbw0gNOlusoX/Je2ZdyA3C EirGvFFtRgUMFG+Qfpt2TNkvCDbZU85UL6jZOI6tIkC8Orw7Vk4DNycza6KMbVkagQaERRN23OK7tV M8q28TgAXMXeK9W4CSroyR8P4vrRaEcF0qcwnSwttuP7vwwonA4R6+Y92YOEWz7ZZSKFaOy7hhXz7U M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/P8AuUcAy8T2cJTioO4I66U0Prng>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:37:15 -0000

ianswett commented on this pull request.



> @@ -2992,9 +2993,8 @@ valid frames? -->
 ## Generating Acknowledgements {#generating-acks}
 
 Endpoints acknowledge all packets they receive and process. However, only
-ack-eliciting packets (see {{QUIC-RECOVERY}}) trigger the sending of an ACK
-frame.  Packets that are not ack-eliciting are only acknowledged when an ACK
-frame is sent for other reasons.
+ack-eliciting packets cause an ACK frame to be sent within the maximum ack delay.  Packets that are not

Formatting nit: This needs to be a new line to make CircleCI happy

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-304950229