Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)

[Jana Iyengar <[e-mail]>]

janaiyengar requested changes on this pull request.

A few comments. I think the enforcement is useful, but requiring it is not necessary.

> @@ -1033,10 +1036,12 @@ longer plans to use that address.
 
 An endpoint can cause its peer to retire connection IDs by sending a
 NEW_CONNECTION_ID frame with an increased Retire Prior To field.  Upon receipt,
-the peer MUST retire the corresponding connection IDs using RETIRE_CONNECTION_ID
-frames.  Failure to retire the connection IDs within approximately one PTO can
-cause packets to be delayed, lost, or cause the original endpoint to send a
-stateless reset in response to a connection ID it can no longer route correctly.
+the peer MUST first retire the corresponding connection IDs using
+NEW_CONNECTION_ID frames and then add the newly provided connection ID to the

```suggestion
RETIRE_CONNECTION_ID frames and then add the newly provided connection ID to the
```

> @@ -4590,8 +4595,14 @@ preferred_address (0x000d):
 active_connection_id_limit (0x000e):
 
 : The maximum number of connection IDs from the peer that an endpoint is willing
-  to store. This value includes only connection IDs sent in NEW_CONNECTION_ID
-  frames. If this parameter is absent, a default of 0 is assumed.
+  to store. This value includes connection IDs sent in NEW_CONNECTION_ID frames,
+  the connection ID used during the handshake as well as the connection ID
+  provided in the preferred_address transport parameter.
+  Unless a zero-length connection ID is being used, the value of the
+  active_connection_id_limit parameter MUST be no less than 2. If this
+  transport parameter is absent, a default of 2 is assumed.
+  When a zero-length connection ID is being used, the active_connection_id_limit
+  parameter MUST NOT be sent.

I think this change is unnecessary and detrimental. Why is this useful?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3201#pullrequestreview-318191803