Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)
Bence Béky <notifications@github.com> Wed, 30 January 2019 13:14 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 268AF1311D8 for <quic-issues@ietfa.amsl.com>; Wed, 30 Jan 2019 05:14:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.574
X-Spam-Level:
X-Spam-Status: No, score=-11.574 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZwQdvcFLGX_B for <quic-issues@ietfa.amsl.com>; Wed, 30 Jan 2019 05:14:12 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 629A11311E5 for <quic-issues@ietf.org>; Wed, 30 Jan 2019 05:14:12 -0800 (PST)
Date: Wed, 30 Jan 2019 05:14:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548854051; bh=FNt/KXnhJFpkWRiBb8/12ffjPlmbkrgppSM2sUxoyB0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HMbQCh1O84Ile8dGvcI78UmgPOq65XVjdqW3enFPT8Hlk1Kr//9qYtow5vlUWGub6 ldWAQvHkjdOykAmO4alciSxA137GuszHOrkFK0T56EyTdj8n0pdcEcB0jpHf+abCi+ ee08vP+8+0xFv6LvJwLYOJDy6g2MBTtA2gc7eBOQ=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2158b91d2711debabede0dddf38b162089cab63e92cf000000011869652392a169ce180fea0e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2379/c458938830@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2379@github.com>
References: <quicwg/base-drafts/pull/2379@github.com>
Subject: Re: [quicwg/base-drafts] Replace the RequireInsertCount decoding algorithm (#2379)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c51a3235abd0_39eb3fb8e3cd45c03753b9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PCSO5V3qyTO4knSQW6f_hGLDpX8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jan 2019 13:14:15 -0000
> Ah, I didn't really intend that an implementation HAD to use this algorithm. An implementation can use any algorithm that produces correct results (or not decode at all, per @dtikhonov's impl that uses the wrapped value to index directly). Given that it's easy to screw up the algorithm, I like having the psuedocode for copy-and-paste/no brainer. > > Therefore, let me make _that_ clear and add normative language for all error cases, but I may also add the check to the algorithm. I understand. In this case, I support adding normative language for checks. Honestly, I interpret "the decoder reconstructs the Required Insert Count using the following algorithm" as indicating that the implementation must use an algorithm that has the exact same behavior as the pseudo-code. Therefore I propose that the error check is added to the pseudo-code as well. Maybe the text could be changed to something like "The decoder reconstructs the Required Insert Count. If the decoder encounters an EncodedInsertCount value that could not have been produced by a conformant encoder, then the decoder MUST signal a stream error. An example algorithm to decode the Required Insert Count is the following.". This would indicate to me that the pseudo-code is non-normative. But I am also just fine with the current text, as long as the requirements (on error checking and everything else) are spelled out both in the text (because you interpret that as normative) and in pseudo-code (because I interpret that as normative). Having consistent text + pseudo-code sounds like a good idea anyway. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2379#issuecomment-458938830
- [quicwg/base-drafts] Replace the RequireInsertCou… afrind
- Re: [quicwg/base-drafts] Replace the RequireInser… Martin Thomson
- Re: [quicwg/base-drafts] Replace the RequireInser… afrind
- Re: [quicwg/base-drafts] Replace the RequireInser… Martin Thomson
- Re: [quicwg/base-drafts] Replace the RequireInser… afrind
- Re: [quicwg/base-drafts] Replace the RequireInser… Bence Béky
- Re: [quicwg/base-drafts] Replace the RequireInser… afrind
- Re: [quicwg/base-drafts] Replace the RequireInser… Bence Béky
- Re: [quicwg/base-drafts] Replace the RequireInser… afrind
- Re: [quicwg/base-drafts] Replace the RequireInser… afrind