Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)

Benjamin Saunders <> Wed, 12 December 2018 17:27 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id DD7E113116B for <>; Wed, 12 Dec 2018 09:27:40 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -4.459
X-Spam-Status: No, score=-4.459 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id o_nrcQTL84fF for <>; Wed, 12 Dec 2018 09:27:38 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by (Postfix) with ESMTPS id D0F0913116E for <>; Wed, 12 Dec 2018 09:27:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed;; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=fsttvtELSQuZijF7P18fdLnxtlY=; b=S91772x8SwlKJXpb 15K/sYE4mbrHqdM8U0ezRagLTa7g0SKBHQ5p8t5GMrXhNPd8EP72a4Z+Ho4W/ATF 5MxI/5xygBDZWhFojAZ8UzaAj/tPsgOlkrwajxR+19NdsoxaUhDkUrAnqxqc0tu9 4dhg6YNrNQyqYF3/Q5UC+6Fo3Yk=
Received: by with SMTP id filter0959p1las1-6935-5C114503-4C 2018-12-12 17:27:31.735948725 +0000 UTC m=+48921.544031028
Received: from (unknown []) by (SG) with ESMTP id gw119ubiTGKiJcWf8Xv8hQ for <>; Wed, 12 Dec 2018 17:27:31.674 +0000 (UTC)
Received: from (localhost []) by (Postfix) with ESMTP id 9C280C0A54 for <>; Wed, 12 Dec 2018 09:27:31 -0800 (PST)
Date: Wed, 12 Dec 2018 17:27:31 +0000
From: Benjamin Saunders <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2113/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Fix to ECN section regarding validation (#2113)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1145039a49b_62a33fa7e44d45c4119958"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: Ralith
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0u3pwyZFY8JqSxqaMaBPdh6Ug3fL3wCwl0Y7 pn/0XObGRawKVXHjSSML/OTiAPmt3MKng2k8UOK6Vq+35+6kVXU5mmId6QlLuwaZGD4Qc6e5g/CryM T/NMXnIh8MfgCdDXf9JytkFtcV1No6Ub703jFLJbL2gq/mL8G/lO/TEqpXT4iA8T4EF6oKW2utEDcI E=
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 12 Dec 2018 17:27:41 -0000

Ralith commented on this pull request.

 * The total increase in ECT(0), ECT(1), and CE counters reported in the ACK
   frame MUST be at least the total number of QUIC packets newly acknowledged in
-  this ACK frame.
+  this ACK frame. Detects if the network remark ECT(0), ECT(1) or CE to
+  Not-ECT.
+If a sender receives an ACK that contains no new acknowledgments, for example
+due to reordering of the ACKs, then ECN counter comparison SHOULD NOT be
+performed. Also if sender do not have state to determine if a particular PSN
+is newly acknowledge or not, then the comparison SHOULD NOT be performed.

This reads to me like the comparison of the new ECN block to the local reference (i.e. the verification procedure) should not be performed if the ACK acknowledges any packets which are outside the window and hence are not guaranteed not to be new acknowledgements. Should it instead indicate that such an acknowledgement should not be counted towards new acknowledgements?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: