Re: [quicwg/base-drafts] Clean up text on Maximum Table Size. (#2115)

Bence Béky <notifications@github.com> Tue, 18 December 2018 16:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0064C130F14 for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 08:28:04 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.059
X-Spam-Level:
X-Spam-Status: No, score=-6.059 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.105, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kYm9hZTeGIRQ for <quic-issues@ietfa.amsl.com>; Tue, 18 Dec 2018 08:28:02 -0800 (PST)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EE0E0130F0B for <quic-issues@ietf.org>; Tue, 18 Dec 2018 08:28:01 -0800 (PST)
Date: Tue, 18 Dec 2018 08:28:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545150481; bh=YjCTYNt50U1yMjWa19PRCamJJTGIeD7iUF27yerYfB8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zZQ73WNLWMeJRBbv71LwHwncfrOGKv6lzTuLLaxPNY/JqiMWyjVh9tn/skamfIQ9u 73tW5Vo2kLZGCnL42dStnTAv+FQQo9CP4+6WchdsyMt4U/E4QDa3MJ2Vuwr4sV5OS2 aYXvDGniv37SkygevbmkwYZTbMbPRxBDT1fGMeXs=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab62b5774794085ecd5a2bcacb6f84c7e521746b5292cf000000011830e21192a169ce173d8649@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2115/review/186160080@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2115@github.com>
References: <quicwg/base-drafts/pull/2115@github.com>
Subject: Re: [quicwg/base-drafts] Clean up text on Maximum Table Size. (#2115)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1920112a68_1db13f875aad45b418482b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PThcpkGlMY8ca0cLi4B_eG2KKR8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 16:28:04 -0000

bencebeky commented on this pull request.



> @@ -768,9 +781,7 @@ end of a stream, it generates a Stream Cancellation instruction on the decoder
 stream.  Similarly, when an endpoint abandons reading of a stream it needs to
 signal this using the Stream Cancellation instruction.  This signals to the
 encoder that all references to the dynamic table on that stream are no longer
-outstanding.  A decoder with a maximum dynamic table size equal to zero (see

I think there is a race here for 0-RTT connections.  Assume the remembered value for SETTINGS_MAXIMUM_DYNAMIC_TABLE_CAPACITY is non-zero.  An endpoint can send a SETTINGS frame with zero SETTINGS_MAXIMUM_DYNAMIC_TABLE_CAPACITY, then send a request and cancel it.  Since the decoder's maximum dynamic table capacity is zero, it does not have to send a Stream Cancellation.  However, the peer might receive the request and send a response using the remembered value of SETTINGS_MAXIMUM_DYNAMIC_TABLE_CAPACITY, inserting entries to the dynamic table.  Those references will never be cleared.

This isssue is intertwined with the one above on the initial value of maximum table capacity on 0-RTT connections.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2115#pullrequestreview-186160080