Re: [quicwg/base-drafts] Editorial suggestions on the Streams section (#2730)

ianswett <notifications@github.com> Fri, 21 June 2019 17:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C39EF120365 for <quic-issues@ietfa.amsl.com>; Fri, 21 Jun 2019 10:39:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kJ8zOcD4zr0T for <quic-issues@ietfa.amsl.com>; Fri, 21 Jun 2019 10:39:33 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F1823120352 for <quic-issues@ietf.org>; Fri, 21 Jun 2019 10:39:30 -0700 (PDT)
Date: Fri, 21 Jun 2019 10:39:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561138770; bh=w8HR3b1HKo6dERgFdeXZF5cRi0CAU1OC9Bds2cnykzE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YYOu0Q9+zRKwm5ebFp8jy2Ju8HhcrwUYWo6UOR+0xcmeGGTHl/lQjCyCIl89kLGi0 Tn0cYYMZtN4IoaAskZEEn+aMyxQU8IuUvOI8dBjbdMWq+1jWosDTSVNOQA2hNVglkh Gg5AByoxyiki/LB+YfryhxelhUyoDPKMwrB17UqU=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK46OUITJBIIY2ZRT2V3DJENDEVBNHHBVGTFHY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2730/review/252946609@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2730@github.com>
References: <quicwg/base-drafts/pull/2730@github.com>
Subject: Re: [quicwg/base-drafts] Editorial suggestions on the Streams section (#2730)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d0d1651efcde_23913f83610cd96492922"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PhOLXayvBC5Z720VBjKE6em0e4I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2019 17:39:35 -0000

ianswett commented on this pull request.

Thanks Mike, I addressed or accepted most of your comments.

> @@ -244,8 +245,9 @@ x (*) ...:
 # Streams {#streams}
 
 Streams in QUIC provide a lightweight, ordered byte-stream abstraction to an

I'm not sure I want to make that change and I'm not changing that sentence at the moment, so if you would like to change it, I'd suggest a separate PR.

> @@ -335,8 +337,9 @@ the flow control limits set by its peer.  Flow control is described in detail in
 Stream multiplexing can have a significant effect on application performance if
 resources allocated to streams are correctly prioritized.
 
-QUIC does not provide frames for exchanging prioritization information.  Instead
-it relies on receiving priority information from the application that uses QUIC.
+QUIC does not provide a mechanism for exchanging prioritization information.
+Instead it relies on receiving priority information from the application that
+uses QUIC.

I added this, then removed it because it read somewhat redundantly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2730#pullrequestreview-252946609