Re: [quicwg/base-drafts] Default settings in HTTP (#2038)

[Lucas Pardue <[e-mail]>]

LPardue requested changes on this pull request.

At a high level this seems ok. I've made some minor comments, feel free to accept/ignore at your leisure.

My only concern with this is that HTTP/3 extensions that require SETTINGS will introduce some blocking when compared to the vanilla HTTP/3 - this might make extensions less attractive to deploy. However, I'd expect most vanilla HTTP/3 deployments to want QPACK, and require SETTINGS exchange... my concerns are probably misplaced

> @@ -660,7 +658,7 @@ HTTP_MALFORMED_FRAME.
 The following settings are defined in HTTP/3:
 
   SETTINGS_NUM_PLACEHOLDERS (0x3):
-  : This value SHOULD be non-zero.  The default value is 16.
+  : This value SHOULD be non-zero.  The default value is 0.

So I never understood why the old value was 16. Zero seems ok but this line, on naive, inspection reads strangely "Should not be zero but is zero by default"

> @@ -678,12 +676,18 @@ Additional settings MAY be defined by extensions to HTTP/3.
 
 #### Initialization
 
-When a 0-RTT QUIC connection is being used, the client's initial requests will
-be sent before the arrival of the server's SETTINGS frame.  Clients MUST store
-the settings the server provided in the session being resumed and MUST comply
-with stored settings until the server's current settings are received.
-Remembered settings apply to the new connection until the server's SETTINGS
-frame is received.
+An HTTP implementation MUST NOT send frames or requests which would be invalid
+based on its current understanding of the peer's settings.  All settings begin
+at an initial value, and are updated upon receipt of a SETTINGS frame.  For
+servers, the initial values of the client's settings are the defaults of each
+setting.

Could you improve this with a more concise statement, such as "For servers, the initial value of each client setting is its default value"?



> @@ -678,12 +676,18 @@ Additional settings MAY be defined by extensions to HTTP/3.
 
 #### Initialization
 
-When a 0-RTT QUIC connection is being used, the client's initial requests will
-be sent before the arrival of the server's SETTINGS frame.  Clients MUST store
-the settings the server provided in the session being resumed and MUST comply
-with stored settings until the server's current settings are received.
-Remembered settings apply to the new connection until the server's SETTINGS
-frame is received.
+An HTTP implementation MUST NOT send frames or requests which would be invalid
+based on its current understanding of the peer's settings.  All settings begin
+at an initial value, and are updated upon receipt of a SETTINGS frame.  For
+servers, the initial values of the client's settings are the defaults of each
+setting.
+
+For clients using a 1-RTT QUIC connection, the initial values of the server's
+settings are the defaults of each setting. When a 0-RTT QUIC connection is being

Change to be consistent with above (if above was accepted)

"the initial value of each server setting is its default value"

> @@ -1014,12 +1014,12 @@ represented as an 8-bit prefix string literal.
 QPACK defines two settings which are included in the HTTP/QUIC SETTINGS frame.
 
   SETTINGS_HEADER_TABLE_SIZE (0x1):
-  : An integer with a maximum value of 2^30 - 1.  The default value is 4,096
+  : An integer with a maximum value of 2^30 - 1.  The default value is zero
     bytes.  See {{table-dynamic}} for usage.

So I've just noticed this setting defines the default to have units of bytes. Do settings have units? Suggest you lose the units.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2038#pullrequestreview-177580770