Re: [quicwg/base-drafts] Think carefully before blowing up (#3344)

ianswett <notifications@github.com> Wed, 15 January 2020 01:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0194712002F for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:01:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZwOnyC2PbPUI for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:01:46 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29CE6120058 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:01:46 -0800 (PST)
Received: from github-lowworker-3a0df0f.ac4-iad.github.net (github-lowworker-3a0df0f.ac4-iad.github.net [10.52.25.92]) by smtp.github.com (Postfix) with ESMTP id 8281B52110A for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:01:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579050105; bh=5+dAEQbAh1l5ASDF/CFmhzobEZQPr1HeCKpOlAHN/os=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=gIunwE40aXprTWklC20ExQxzIUiFbGvj5ArfRooXmIHTLcMUOrcdUeZuLNropfeXM gsDeYz+aI8tuvAzlLnEGe5p8Emgs5VgCoLxSDjm4NCMaMDU3B0MrX91shT0BZ+Trhc pDR0C0NobL5iZGPvWDGnH+i9RjfiqXrk5RYcEQwI=
Date: Tue, 14 Jan 2020 17:01:45 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5L3H34GQR3STATG3F4FOLPTEVBNHHCBRUN3U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3344/review/342935499@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3344@github.com>
References: <quicwg/base-drafts/pull/3344@github.com>
Subject: Re: [quicwg/base-drafts] Think carefully before blowing up (#3344)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1e64797402e_60013f8d2a2cd96c158011"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PmnfXzly_SD4Sx82zFyrqUSZlCM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 01:01:53 -0000

ianswett approved this pull request.



> +An endpoint MAY choose to treat a stream error as a connection error under
+certain circumstances.  Implementations need to consider the impact on
+outstanding requests before making this choice.

In that case, I believe Chrome was sending a RESET_STREAM after the stream had been closed, which is technically legal, but unnecessary.  And your implementation immediately closed the connection in response to a RESET_STREAM on an already closed stream, causing Chrome to mark QUIC as 'broken' for 5 minutes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3344#pullrequestreview-342935499