Re: [quicwg/base-drafts] Extension frames (#1068)
Kazuho Oku <notifications@github.com> Wed, 04 April 2018 16:33 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 84BE3127978 for <quic-issues@ietfa.amsl.com>; Wed, 4 Apr 2018 09:33:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.01
X-Spam-Level:
X-Spam-Status: No, score=-7.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wV3sUaSbN4jV for <quic-issues@ietfa.amsl.com>; Wed, 4 Apr 2018 09:33:29 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76E3A126D3F for <quic-issues@ietf.org>; Wed, 4 Apr 2018 09:33:29 -0700 (PDT)
Date: Wed, 04 Apr 2018 09:33:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1522859608; bh=JW5nPkAgyj5PQ8++9mOCrenvpVV0G7+D88fDl2Pvn1o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=g2YLLTHYQrMoKQ8iAZmqT/yisX//pRB+OYveGUmHmZw0hAV1XoagJjDWLduzsduxC pV3cG9stpIulmE0iydqkvLEa6t6NqEb2kZoHP7ydT/9o2mta6qe/RXuSO6O0Pny6Sa DPMP3QBszSKU+/BQpEsjvrx7ZARRr2BiqkeAWxfA=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab76496a77b3dd13f330b40da8949d75fbe3c5653e92cf0000000116dcc05892a169ce115ea54e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1068/c378663899@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1068@github.com>
References: <quicwg/base-drafts/pull/1068@github.com>
Subject: Re: [quicwg/base-drafts] Extension frames (#1068)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ac4fe589a012_1abc2b1eaddf2ec814198a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PnUwFG1LdNpWi6Q1hPJfagEgkXI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Apr 2018 16:33:31 -0000
I do not have a strong opinion on if we should use TP for negotiating extensions, however I agree with @ekr that doing some negotiation in TP and some by using frames seems awkward to me. It might make sense to do all in TP or do all in frames (as we have done in HTTP/2). I have two other concerns about the proposed approach. The first concern is the approach expecting an extension to always introduce a new frame type. I wonder if that assumption would always be true. Consider the case when we would have a different PNE mechanism. Use of the mechanism needs to be negotiated. However, it would not introduce a new frame; since it just changes how the packet is formatted. Therefore, I'd prefer defining a mapping that maps a feature to *zero* or more frame IDs, rather than a one-to-one mapping. The second concern is frame_type getting ossified. Consider the case when we adopt the first extension named Foo. Implementations that only support Foo will likely assign 0x80 as the frame_type (endpoints can unilaterally declare the mapping). The same frame_type (0x80) will be used to designate the same extension, when sending *and* receiving. My fear is that I doubt if we can be sure that all the implementations will work correctly even in case different frame_types are assigned for sending and receiving the extension in such scenario. However, unless all implementations succeed in implementing it correctly, the frame_type will become ossified. Therefore, I'd prefer greasing the frame_type. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1068#issuecomment-378663899
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… Martin Thomson
- [quicwg/base-drafts] Add EXTENSION frame (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… janaiyengar
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… martinduke
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… Christian Huitema
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… Christian Huitema
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… janaiyengar
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… Christian Huitema
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… mirjak
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… MikkelFJ
- Re: [quicwg/base-drafts] Extension frames (#1068) Kazuho Oku
- Re: [quicwg/base-drafts] Add EXTENSION frame (#10… Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Dmitri Tikhonov
- Re: [quicwg/base-drafts] Extension frames (#1068) ekr
- Re: [quicwg/base-drafts] Extension frames (#1068) Kazuho Oku
- Re: [quicwg/base-drafts] Extension frames (#1068) Christian Huitema
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) ekr
- Re: [quicwg/base-drafts] Extension frames (#1068) Rui Paulo
- Re: [quicwg/base-drafts] Extension frames (#1068) Mike Bishop
- Re: [quicwg/base-drafts] Extension frames (#1068) Mike Bishop
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Rui Paulo
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) MikkelFJ
- Re: [quicwg/base-drafts] Extension frames (#1068) Kazuho Oku
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) ekr
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson
- Re: [quicwg/base-drafts] Extension frames (#1068) Kazuho Oku
- Re: [quicwg/base-drafts] Extension frames (#1068) ekr
- Re: [quicwg/base-drafts] Extension frames (#1068) Martin Thomson