IETF Logo Mail Archive

Re: [quicwg/base-drafts] Placeholder -1 (#2690)

Kazuho Oku <notifications@github.com> Sat, 11 May 2019 00:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EC22312028A for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:29:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.392
X-Spam-Level:
X-Spam-Status: No, score=-1.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W6-om06vahwp for <quic-issues@ietfa.amsl.com>; Fri, 10 May 2019 17:29:52 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A20231202E6 for <quic-issues@ietf.org>; Fri, 10 May 2019 17:10:03 -0700 (PDT)
Date: Fri, 10 May 2019 17:09:59 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557533399; bh=a1F4iFGowk6eNrHrO36SpadbWSdiDSMrr7Bu2AyMfTs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yYNu3nMUNTpTHalyQaBaeC6VfuthCb5h61f2N++nP/JAP3HWzDvxbOEXVspWI75Tz mW8yZhw7FAq/8UgFPQfl3btAy0jZXSzp2qYSqYkQdUTaqgU2t4Mmra6SAFVJImOjQj HBwOyRwSOoDNduueU5Obs1Bh9c9rOWkgxwWTmLew=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYYQYQ6JPQBQXC4DGV24NCVPEVBNHHBUZJ65I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2690/review/236351251@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2690@github.com>
References: <quicwg/base-drafts/pull/2690@github.com>
Subject: Re: [quicwg/base-drafts] Placeholder -1 (#2690)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd612d79e274_258a3fea16acd95c9453c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PvtoykgDECFthyyru3pklchNxRc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2019 00:29:57 -0000

kazuho commented on this pull request.

Nice work! LGTM module the point below.

> @@ -1102,18 +1109,33 @@ that can be prioritized are:
 
 Taken together, the dependencies across all prioritized elements in a connection
 form a dependency tree. An element can depend on another element or on the root
-of the tree. A reference to an element which is no longer in the tree is treated
-as a reference to the root of the tree. The structure of the dependency tree
-changes as PRIORITY frames modify the dependency links between prioritized
-elements.
-
-Due to reordering between streams, an element can also be prioritized which is
-not yet in the tree. Such elements are added to the tree with the requested
-priority.
+of the tree.  The tree also contains a dedicated placeholder with index "-1"

Could we call it something else than "-1" placeholder? Maybe "orphan placeholder".

The reason I feel uncomfortable with calling it "-1" are:
* It is not actually an index.
* We already have a placeholder that is called by name "root".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2690#pullrequestreview-236351251

v2.23.0 | Report a Bug | By Email