Re: [quicwg/base-drafts] Discard inconsistent packets (#2431)

MikkelFJ <notifications@github.com> Thu, 07 February 2019 07:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1F2FD12F1AB for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 23:15:15 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8Z4jKahppaKe for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 23:15:13 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E4F11228B7 for <quic-issues@ietf.org>; Wed, 6 Feb 2019 23:15:13 -0800 (PST)
Date: Wed, 06 Feb 2019 23:15:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549523712; bh=Kv8jo7npsRTfqWB0mX/K4Kw2PysC1Bqjf7eeEFaliGM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=s2Fi9XRNGyrgjQE3hc9c3k4oYnuFQR+EC0NjLG5D9/HNc36fdjEq4ZqJnDV+SdIha TuDRfE9MuIm/AcgDgCoMUTnfrDw7Y3xOeywaOgaeTHADu+Fih0OfqzbDLGYiOFh60z OZWzUGneLp0EB7ADtdgClcN2teAZjAcdaqpV3tJs=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc84a2a75a5ff27e8ee17174ae165563f2e26831792cf0000000118739d0092a169ce18483443@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2431/review/200944522@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2431@github.com>
References: <quicwg/base-drafts/pull/2431@github.com>
Subject: Re: [quicwg/base-drafts] Discard inconsistent packets (#2431)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5bdb00132a6_4ab93f8f004d45bc433742"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PwFanQPiWm_L2RWzbxwrOM4FAA0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Feb 2019 07:15:15 -0000

mikkelfj commented on this pull request.



> @@ -1010,8 +1010,10 @@ Endpoints can send a Stateless Reset ({{stateless-reset}}) for any packets that
 cannot be attributed to an existing connection. A stateless reset allows a peer
 to more quickly identify when a connection becomes unusable.
 
-Packets that are matched to an existing connection, but for which the endpoint
-cannot remove packet protection, are discarded.
+Packets that are matched to an existing connection are discarded if the packets
+are inconsistent with the state of that connection -- for example, if they
+indicate a different protocol version than that of the connection, or if the
+removal of packet protection is unsuccessful.

```suggestion
removal of packet protection is unsuccessful once the expected keys are available.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2431#pullrequestreview-200944522