Re: [quicwg/base-drafts] Ack-eliciting, not inflight (#2117)

ianswett <notifications@github.com> Mon, 17 December 2018 21:11 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 550A512958B for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 13:11:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.056
X-Spam-Level:
X-Spam-Status: No, score=-3.056 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SqFB2TU1ZDxT for <quic-issues@ietfa.amsl.com>; Mon, 17 Dec 2018 13:11:20 -0800 (PST)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A53C4126F72 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 13:11:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=HhzBL8+o3eXGCqOBLZq/fysNua8=; b=jktILSCIiJ9oAxVe g8s63xGWJV9xpdUNzWsKVNn6dIocg59E9RjeLFy5RIrGoEjX4stjD0WnRDF9rRTN I7uFl6/v4Mmfm52T+b67MYVp+MRKfUXOffMCfgHWGE5mbA80kjE6RzIup0ptp49l bCd9aMdLWunbZwhK55NOhvQqDVQ=
Received: by filter1687p1mdw1.sendgrid.net with SMTP id filter1687p1mdw1-30568-5C1810F6-1A 2018-12-17 21:11:18.709924494 +0000 UTC m=+3764.767769589
Received: from github-lowworker-56a5eb2.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0012p1iad2.sendgrid.net (SG) with ESMTP id UruPIFCOR8GhV1H_5om8qg for <quic-issues@ietf.org>; Mon, 17 Dec 2018 21:11:18.625 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-56a5eb2.cp1-iad.github.net (Postfix) with ESMTP id A4AC7C10D5 for <quic-issues@ietf.org>; Mon, 17 Dec 2018 13:11:18 -0800 (PST)
Date: Mon, 17 Dec 2018 21:11:18 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf8616bec1cd87483440ab93320a224f5622432af92cf00000001182fd2f692a169ce173f2c8b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2117/review/185799953@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2117@github.com>
References: <quicwg/base-drafts/pull/2117@github.com>
Subject: Re: [quicwg/base-drafts] Ack-eliciting, not inflight (#2117)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1810f6a1d09_67ed3fa85b8d45bc11988b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2vHRmr0sB69gHq8odwIYVmTmiFQhItjs00sv 1pAec5HPY5cAUlI/PNrf4qCLqleKmzJUoXPzowRfqMXwnkdwJirS4J1COgJ4M5GzqwI4UGlMXh5UwG ugYWgzaB+FHb5XuB3kWkjQztr5GqNiEcTFqq1gk/8uJ4ZwjjOOcw2O+hzTMkvMfFdmt88GBjjH0Xe/ Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PwVWtIncmadTk4Byvcs_u46N0QM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Dec 2018 21:11:22 -0000

ianswett commented on this pull request.



> @@ -792,7 +792,7 @@ Pseudocode for SetLossDetectionTimer follows:
  SetLossDetectionTimer():
     // Don't arm timer if there are no ack-eliciting packets
     // in flight.
-    if (bytes_in_flight == 0):
+    if (no ack-eliciting packets outstanding):

```suggestion
     if (no ack-eliciting packets in flight):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2117#pullrequestreview-185799953