Re: [quicwg/base-drafts] Make congestion control more self-contained (#3463)

Martin Thomson <notifications@github.com> Tue, 25 February 2020 23:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 359073A08D7 for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 15:53:53 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.099
X-Spam-Level:
X-Spam-Status: No, score=-3.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z-wi6KZgWUpp for <quic-issues@ietfa.amsl.com>; Tue, 25 Feb 2020 15:53:51 -0800 (PST)
Received: from out-28.smtp.github.com (out-28.smtp.github.com [192.30.252.211]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9DBA3A08D5 for <quic-issues@ietf.org>; Tue, 25 Feb 2020 15:53:51 -0800 (PST)
Received: from github-lowworker-56fcc46.va3-iad.github.net (github-lowworker-56fcc46.va3-iad.github.net [10.48.102.32]) by smtp.github.com (Postfix) with ESMTP id ECECF8C10BE for <quic-issues@ietf.org>; Tue, 25 Feb 2020 15:53:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582674830; bh=iqfQ0h/YjyjwORSyIop2CRZFnJbLCiN3rO8xiib3ywE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pwztGIPvhjdVlgqDPAOw1Bctnq+pKUnTxvx9IkPvcR2S+0qahkLYxEnBCJKAhMnEE 2gcXJ/9foZRNV4zHV9fcjMGhXav89gvCuDI5DBTaaSM0WRerFcCvo5MfX/vJUz20pd 0O98UkgktFWoItIlycrnthkLnEG7XV4DuLCMWRVE=
Date: Tue, 25 Feb 2020 15:53:50 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZDI6AF2LBXCZSZ2NN4MLTA5EVBNHHCDOL7KI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3463/review/364528679@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3463@github.com>
References: <quicwg/base-drafts/pull/3463@github.com>
Subject: Re: [quicwg/base-drafts] Make congestion control more self-contained (#3463)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e55b38eddc1c_5b803fd64f6cd968857aa"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/PyIRiSW-oj5dj7oZRU9-ENmdRzU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Feb 2020 23:53:53 -0000

martinthomson approved this pull request.



> @@ -659,21 +660,37 @@ treats a Congestion Experienced(CE) codepoint in the IP header as a signal of
 congestion. This document specifies an endpoint's response when its peer
 receives packets with the Congestion Experienced codepoint.
 
+## Initial and Minimum Congestion Window {#initial-cwnd}
+
+QUIC begins every connection in slow start with the congestion window set to
+an initial value.  The RECOMMENDED initial value is the minimum of
+10 * max_datagram_size and max(2 * max_datagram_size, 14720)).  This follows

Endpoints SHOULD use an initial congestion window of 10 times the maximum datagram size (max_datagram_size), limited to the larger of 14720 or twice the maximum datagram size.

> @@ -1257,10 +1274,7 @@ and common practice.
 kInitialWindow:
 : Default limit on the initial amount of data in flight, in bytes.
   The RECOMMENDED value is the minimum of 10 * max_datagram_size and

use min(10 * max_datagram_size, max(2 * max_datagram_size, 14720)))

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3463#pullrequestreview-364528679