IETF Logo Mail Archive

Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)

afrind <notifications@github.com> Mon, 16 July 2018 21:39 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A267513129B for <quic-issues@ietfa.amsl.com>; Mon, 16 Jul 2018 14:39:47 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dRPSM0l4pB2V for <quic-issues@ietfa.amsl.com>; Mon, 16 Jul 2018 14:39:45 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 389DA131285 for <quic-issues@ietf.org>; Mon, 16 Jul 2018 14:39:45 -0700 (PDT)
Date: Mon, 16 Jul 2018 14:39:44 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531777184; bh=STrwsxZSILv303UGlhPkXLtOTEpc4WoYSDIZhuuL8hE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r8OaOlJ/iUwGTBTtzlnLhQdOLDCdMwTSubsba8Jh3KgnrFFBbn2uIMw5MmyvW09bE hUfyew49JxhcWw8kGjwEJN0sz4sPRfBkOydaM0763clmGi7z9y66O5u6j+q3OZWrHC RQY/jb7jBqK4x4uECJeDq+Oj5QLkKQrC1eZAHuVk=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5af1823ea3b4fec6ed158d520a2e3180c108077692cf000000011764d2a092a169ce14546a14@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1556/405390338@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1556@github.com>
References: <quicwg/base-drafts/issues/1556@github.com>
Subject: Re: [quicwg/base-drafts] HTTP SETTINGS: define setting content encoding (#1556)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4d10a080932_2a442ac15efb2f5849511d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Q0iN7L2vr4D0NqX6ZXTCoWhqeWs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Jul 2018 21:39:57 -0000

@LPardue I think for boolean it's 0 `Length` and no content.

I agree that externalizing the length is good to skip unknown settings.  I'm not a fan of the implicit boolean false either, it's much safer to make things explicit.  SETTINGS are not so frequent or large that we need to apply QPACKian levels of byte squeezing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1556#issuecomment-405390338

v2.23.0 | Report a Bug | By Email