Re: [quicwg/base-drafts] Limit connection drops from Version Negotiation (#3533)

Jana Iyengar <notifications@github.com> Thu, 19 March 2020 00:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A3373A1E8E for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 17:07:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.696
X-Spam-Level:
X-Spam-Status: No, score=-1.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M-BInaM5MjbD for <quic-issues@ietfa.amsl.com>; Wed, 18 Mar 2020 17:07:23 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BEC023A1E86 for <quic-issues@ietf.org>; Wed, 18 Mar 2020 17:07:23 -0700 (PDT)
Received: from github-lowworker-9d2806a.ash1-iad.github.net (github-lowworker-9d2806a.ash1-iad.github.net [10.56.102.50]) by smtp.github.com (Postfix) with ESMTP id C082166054D for <quic-issues@ietf.org>; Wed, 18 Mar 2020 17:07:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584576442; bh=V2Rzx1nl3Arge5GdrV1Bc5o0WSrJJCN+/iOrFBP6IeE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=szM81W0ygxId63H56lVdoP+KdIKa2wvjykZ7HBFnyvv+YFOt4tUoOXjSrO6EjZ+a1 AN8PNeCcfo0QgXOtwKcq/5j9RjyA+TAE9zVgAQyyTgzl1YEo2ovksgEsyVJRxuZN+p rF6Ja3vyxaW+MvAdMCLozO4Uv1fY7v+qUwQOoHjI=
Date: Wed, 18 Mar 2020 17:07:22 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3Y7Y77WUWCZGXLVDV4P2MLVEVBNHHCFT6HRA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3533/review/377319265@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3533@github.com>
References: <quicwg/base-drafts/pull/3533@github.com>
Subject: Re: [quicwg/base-drafts] Limit connection drops from Version Negotiation (#3533)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e72b7baaf3ff_6d5e3f8c3becd96415352b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Q4aaxmBDIUtUvTulKmrHZuA0bOw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Mar 2020 00:07:26 -0000

janaiyengar commented on this pull request.

Some editorial suggestions.

> +A client that supports only this version of QUIC MUST abandon the current
+connection attempt if it receives a Version Negotiation packet.  However, a
+client MUST discard any Version Negotiation packet if is has received and
+successfully processed a packet.  In addition, a client MUST discard a Version
+Negotiation packet that lists the QUIC version selected by the client.

```suggestion
A client that supports only this version of QUIC MUST abandon the current
connection attempt if it receives a Version Negotiation packet, with the
following two exceptions. A client MUST discard any Version Negotiation packet
if is has received and successfully processed any other packet, including an
earlier Version Negotiation packet. A client MUST discard a Version Negotiation
packet that lists the QUIC version selected by the client.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3533#pullrequestreview-377319265