Re: [quicwg/base-drafts] Intentional delay since the largest acknowledged (#3356)

Martin Thomson <notifications@github.com> Mon, 20 January 2020 05:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3F057120099 for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 21:59:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SBKZ8MYbt3P7 for <quic-issues@ietfa.amsl.com>; Sun, 19 Jan 2020 21:59:34 -0800 (PST)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DABC120043 for <quic-issues@ietf.org>; Sun, 19 Jan 2020 21:59:34 -0800 (PST)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id 31F645211FD for <quic-issues@ietf.org>; Sun, 19 Jan 2020 21:59:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579499973; bh=y3RvrFYl9YU3zC3f3HBoRT7Jsq2TeTTxdQEEz4ZJN7o=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=CU5tur/s1yNw2Cq80kXzihWx+DpJcChE+/gFwDpqU5uMddZx0UEUs4N541r6zfMj1 gQxCB0OdCrK3SIShZSQHgpEn6Yn8gNpjfpnbveylRdHp8bwdZWXWXE4EBzG6YtUI+e l2ksXXw15Wjzc8OMaPzQekp8OFP3kyCo/CxqkewY=
Date: Sun, 19 Jan 2020 21:59:33 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYGBTVOL66OR3JVC4V4GJ2ELEVBNHHCBYDLJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3356/review/345091768@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3356@github.com>
References: <quicwg/base-drafts/pull/3356@github.com>
Subject: Re: [quicwg/base-drafts] Intentional delay since the largest acknowledged (#3356)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e2541c522c44_2dde3fb2374cd960389af"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Q9Q15Hfmm2HCB1oPY0cTBI2iAWU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2020 05:59:36 -0000

martinthomson requested changes on this pull request.



> @@ -3241,15 +3241,14 @@ received packets in preference to packets received in the past.
 
 ### Measuring and Reporting Host Delay {#host-delay}
 
-An endpoint measures the delays intentionally introduced between when an
-ack-eliciting packet is received and the corresponding acknowledgment is sent.
-The endpoint encodes this delay for the largest acknowledged packet in the Ack
-Delay field of an ACK frame (see {{frame-ack}}). This allows the receiver of the
-ACK to adjust for any intentional delays, which is important for getting a
-better estimate of the path RTT when acknowledgments are delayed. A packet might
-be held in the OS kernel or elsewhere on the host before being processed.  An
-endpoint MUST NOT include delays that is does not control when populating the
-Ack Delay field in an ACK frame.
+An endpoint measures the delays intentionally introduced between when the
+largest packet is received and an acknowledgment is sent. The endpoint encodes

"largest" means number of bytes, right?

```suggestion
packet with the largest packet number is received and an acknowledgment is sent. The endpoint encodes
```

> -An endpoint measures the delays intentionally introduced between when an
-ack-eliciting packet is received and the corresponding acknowledgment is sent.
-The endpoint encodes this delay for the largest acknowledged packet in the Ack
-Delay field of an ACK frame (see {{frame-ack}}). This allows the receiver of the
-ACK to adjust for any intentional delays, which is important for getting a
-better estimate of the path RTT when acknowledgments are delayed. A packet might
-be held in the OS kernel or elsewhere on the host before being processed.  An
-endpoint MUST NOT include delays that is does not control when populating the
-Ack Delay field in an ACK frame.
+An endpoint measures the delays intentionally introduced between when the
+largest packet is received and an acknowledgment is sent. The endpoint encodes
+this delay in the Ack Delay field of an ACK frame (see {{frame-ack}}). This
+allows the receiver of the ACK to adjust for any intentional delays, which is
+important for getting a better estimate of the path RTT when acknowledgments are
+delayed. A packet might be held in the OS kernel or elsewhere on the host before
+being processed.  An endpoint MUST NOT include delays that is does not control

The benefit of proof reading:

```suggestion
being processed.  An endpoint MUST NOT include delays that it does not control
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3356#pullrequestreview-345091768