Re: [quicwg/base-drafts] Forwarding status of errors on streams (#3303)

ianswett <notifications@github.com> Mon, 23 December 2019 14:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 71A3B1200C3 for <quic-issues@ietfa.amsl.com>; Mon, 23 Dec 2019 06:49:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E-fFzcWMYma8 for <quic-issues@ietfa.amsl.com>; Mon, 23 Dec 2019 06:49:00 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 85D6E1200C7 for <quic-issues@ietf.org>; Mon, 23 Dec 2019 06:49:00 -0800 (PST)
Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id A5913A0499 for <quic-issues@ietf.org>; Mon, 23 Dec 2019 06:48:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1577112539; bh=l3x3hOBoS1YD2PZp0jxsPH2xgEhqRaOAc0Kmrs7vu5U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fdug6fHqzczYFvhs8fSjVnFA0zYyKScomFMy7Wo4CO3GJurNRJBddQqlAjMpPax6v EolOKo1Lesh+LiLEWJagbacYYZDG+tiN1l3+vx7UoBpweyOSG69Xlk+Fe/oCUzBWgd tm26621VMrsPtonGbY9Gh9qI7ypHbZUXNaE5LOLQ=
Date: Mon, 23 Dec 2019 06:48:59 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5FYEYKWIDOCGUVOU54BYDFXEVBNHHCAHIHBM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3303/review/335889496@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3303@github.com>
References: <quicwg/base-drafts/pull/3303@github.com>
Subject: Re: [quicwg/base-drafts] Forwarding status of errors on streams (#3303)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e00d3db97675_14333f81738cd96093473f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QAno8Nh0mkKj5mdEhHkaKimTQA4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Dec 2019 14:49:02 -0000

ianswett requested changes on this pull request.

The more I look at this, the more I wonder what the full impact is.  It ends up precluding a wide set of errors from becoming connection level errors in order to deal more gracefully with buggy implementations or inadvertent disconnects.

How about scoping this down only to cases when the stream is abruptly terminated(ie: reset) and not all the data was transferred.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3303#pullrequestreview-335889496