IETF Logo Mail Archive

Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)

mirjak <notifications@github.com> Fri, 11 September 2020 14:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B19043A09DE for <quic-issues@ietfa.amsl.com>; Fri, 11 Sep 2020 07:17:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RFa-DpMC8wDK for <quic-issues@ietfa.amsl.com>; Fri, 11 Sep 2020 07:17:44 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B0EA3A09DA for <quic-issues@ietf.org>; Fri, 11 Sep 2020 07:17:44 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id 868CB5C0EE6 for <quic-issues@ietf.org>; Fri, 11 Sep 2020 07:17:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1599833863; bh=45qg0Yd+/ALFGrlC8neET3NSl6bbLiH4UFikmTl9P14=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kqg4OqEysxDubYY77ASv/z2n/ISFz5jRmfZ6owznSvc/5rw22PtVqhBm/Bdhl99Xe gNfTGlIrXleed3UQp9eD5shEgOjcQx2QFpI1kEVQBTXglbd/woR0nFZEf1bRo+EdSB RJx90rPIBJJ6My7lEGx5VMC/wqFKOJa1FvXYaWgs=
Date: Fri, 11 Sep 2020 07:17:43 -0700
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZUNGOESXPWJCFT7VV5M5UAPEVBNHHCR5CFZA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4059/review/486847189@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4059@github.com>
References: <quicwg/base-drafts/pull/4059@github.com>
Subject: Re: [quicwg/base-drafts] Gorry's ECN rewrite (#4059)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f5b870777fab_7e4d19f0773b0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QBsuuln_iT_LZLT5N9nB-nKurLg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2020 14:17:46 -0000

@mirjak commented on this pull request.



>  
-* If all packets that were sent with the ECT(0) codepoint are eventually deemed
-  lost (Section 6 of {{QUIC-RECOVERY}}), validation is deemed to have failed.
+If an endpoint has cause to expect that IP packets with an ECT codepoint might

I think we discussed this all ready once. I'm fine with 10 packet as it's the initial window (but maybe that's what we should say), however, given the result is the same I would rather state it as enable ECT marking and if all packet of your first flight are lost validation fails and you disable. Describing this specifically as probably makes it just sounds more complicated that it is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4059#discussion_r487075657

v2.29.0 | Report a Bug | By Email | System Status