Re: [quicwg/base-drafts] Fix congestion control permissiveness (#3248)

Gorry Fairhurst <notifications@github.com> Tue, 19 November 2019 02:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12D121200B8 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 18:14:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id krKoe29s-Xtg for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 18:14:22 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D0C612004E for <quic-issues@ietf.org>; Mon, 18 Nov 2019 18:14:22 -0800 (PST)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39]) by smtp.github.com (Postfix) with ESMTP id A00558C0E55 for <quic-issues@ietf.org>; Mon, 18 Nov 2019 18:14:21 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574129661; bh=6NZHcv2jsTh8y1RCK0EIKqnlXScfAgS5tLxAnF+LP0A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fXqvppYYwC61Vu9on6NdlunRZ6Ta/Y8r0Dd065FUeTZUS3yol/oFsNkyvLmtWs5W4 SRutZpago2FcIqclVZk9X9EX6KX6muIuybAsXYdebFzn5PYv6Q4lrcvvJzQMj9nFus I2StEOa+PPpRH4T6Rc8c18CLUVGlOp6D7B3tRDwU=
Date: Mon, 18 Nov 2019 18:14:21 -0800
From: Gorry Fairhurst <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5GBH6XDBTJVM7NPP534CBH3EVBNHHB6OVESM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3248/review/318747289@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3248@github.com>
References: <quicwg/base-drafts/pull/3248@github.com>
Subject: Re: [quicwg/base-drafts] Fix congestion control permissiveness (#3248)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd34ffd90e03_59033fcb208cd96416230"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gorryfair
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QFWv7qO-245NqdbAvwLkEwpAuIw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 02:14:24 -0000

gorryfair commented on this pull request.



>  
-QUIC hosts MUST NOT send packets if they would increase bytes_in_flight (defined
-in {{vars-of-interest}}) beyond the available congestion window, unless the
-packet is a probe packet sent after a PTO timer expires, as described in
-{{pto}}.
+Endpoints can unilaterally choose a different algorithm to use, such as Cubic

I think this could reads slightly  better if we swapped these two sentences. First state is generic - then that you can choose different alg.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3248#pullrequestreview-318747289