Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)

ianswett <notifications@github.com> Wed, 16 October 2019 17:02 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E38CE1209A4 for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 10:02:31 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.999
X-Spam-Level:
X-Spam-Status: No, score=-2.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UOOglarGBVuH for <quic-issues@ietfa.amsl.com>; Wed, 16 Oct 2019 10:02:28 -0700 (PDT)
Received: from o10.sgmail.github.com (o10.sgmail.github.com [167.89.101.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A2AC61209A1 for <quic-issues@ietf.org>; Wed, 16 Oct 2019 10:02:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/G0ZOLzTz5UpuFk7/og+G6lQNLU=; b=XDpn7a1WgHexZ/xg vblMDnNLV781mV1dPoT501GYs+lv6YxXw+Kp6EciJBKLCAqpf0ZWCO9nhWGtX78m 5+4pf+vpW23HrRg9CBpaS36+szPOYAWqoOJsDdRJKFBxvp7TDFlGDf2ooiz5YtTe QZwm3/pmOFOAgfdL0bUXq3edDM4=
Received: by filter0803p1las1.sendgrid.net with SMTP id filter0803p1las1-340-5DA74D20-16 2019-10-16 17:02:24.275182254 +0000 UTC m=+494030.554964317
Received: from github-lowworker-d93c4b6.va3-iad.github.net (unknown [140.82.115.64]) by ismtpd0046p1iad2.sendgrid.net (SG) with ESMTP id 8t3yHB1yTxCSIGUsw5K0bw for <quic-issues@ietf.org>; Wed, 16 Oct 2019 17:02:24.247 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-d93c4b6.va3-iad.github.net (Postfix) with ESMTP id 30AEC2A1D1D for <quic-issues@ietf.org>; Wed, 16 Oct 2019 10:02:24 -0700 (PDT)
Date: Wed, 16 Oct 2019 17:02:24 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3QGBOBFXZMUEXLY6V3WSG3BEVBNHHB4RTQYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3098/review/302730503@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3098@github.com>
References: <quicwg/base-drafts/pull/3098@github.com>
Subject: Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da74d202f5f7_53913fb6f08cd96c18248b"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0jbHNs/etLpV3LvyiLIUafoaN082l5ZMAZ4Z yXZPXjalOLw7/09oK9NAndokYq3U7feZmWtiZHPi4SQGNHF7yCV901LQySFypStXNRyqIhbBVwe5gb 3alNHQ7TQroi8QJYLdyIhIx8Fl05hPYnrQbdFHWQOnY//DuNaEWU8c2wQQ==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QGINkfTVy1WeJI6zWN675GjB09o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 17:02:32 -0000

ianswett approved this pull request.



> @@ -167,8 +168,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   performance of the QUIC handshake and use shorter timers for
   acknowledgement.
 
-* Packets that contain only ACK frames do not count toward congestion control
-  limits and are not considered in-flight.
+* Packets that contain only ACK or CONNECTION_CLOSE frames do not count toward

We could reword this sentence to be parallel to the above definition and flip the sentence, ie: 
"Packets containing frames besides ACK or CONNECTION_CLOSE count toward congestion control limits and are considered in-flight."

> @@ -192,8 +192,9 @@ QUIC packet:
 
 Ack-eliciting Packet:
 
-: A QUIC packet that contains frames other than ACK and PADDING. These cause a
-  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
+: A QUIC packet that contains frames other than ACK, PADDING, and
+  CONNECTION_CLOSE. These cause a recipient to send an acknowledgment (see

It would be, but it wouldn't really matter because the connection will close.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-302730503