Date: Wed, 16 Oct 2019 17:02:24 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3QGBOBFXZMUEXLY6V3WSG3BEVBNHHB4RTQYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3098/review/302730503@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3098@github.com>
References: <quicwg/base-drafts/pull/3098@github.com>
Subject: Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5da74d202f5f7_53913fb6f08cd96c18248b";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QGINkfTVy1WeJI6zWN675GjB09o>

----==_mimepart_5da74d202f5f7_53913fb6f08cd96c18248b
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett approved this pull request.



> @@ -167,8 +168,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   performance of the QUIC handshake and use shorter timers for
   acknowledgement.
 
-* Packets that contain only ACK frames do not count toward congestion control
-  limits and are not considered in-flight.
+* Packets that contain only ACK or CONNECTION_CLOSE frames do not count toward

We could reword this sentence to be parallel to the above definition and flip the sentence, ie: 
"Packets containing frames besides ACK or CONNECTION_CLOSE count toward congestion control limits and are considered in-flight."

> @@ -192,8 +192,9 @@ QUIC packet:
 
 Ack-eliciting Packet:
 
-: A QUIC packet that contains frames other than ACK and PADDING. These cause a
-  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
+: A QUIC packet that contains frames other than ACK, PADDING, and
+  CONNECTION_CLOSE. These cause a recipient to send an acknowledgment (see

It would be, but it wouldn't really matter because the connection will close.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-302730503
----==_mimepart_5da74d202f5f7_53913fb6f08cd96c18248b
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> approved this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3098#discussion_r335595666">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -167,8 +168,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   performance of the QUIC handshake and use shorter timers for
   acknowledgement.
 
-* Packets that contain only ACK frames do not count toward congestion control
-  limits and are not considered in-flight.
+* Packets that contain only ACK or CONNECTION_CLOSE frames do not count toward
</pre>
<p>We could reword this sentence to be parallel to the above definition and flip the sentence, ie:<br>
"Packets containing frames besides ACK or CONNECTION_CLOSE count toward congestion control limits and are considered in-flight."</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3098#discussion_r335596209">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -192,8 +192,9 @@ QUIC packet:
 
 Ack-eliciting Packet:
 
-: A QUIC packet that contains frames other than ACK and PADDING. These cause a
-  recipient to send an acknowledgment (see {{sending-acknowledgements}}).
+: A QUIC packet that contains frames other than ACK, PADDING, and
+  CONNECTION_CLOSE. These cause a recipient to send an acknowledgment (see
</pre>
<p>It would be, but it wouldn't really matter because the connection will close.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications&amp;email_token=AFTOJK45L6ETFZ33NLTHRZ3QO5CKBA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFU2BY#pullrequestreview-302730503">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK73R7BCL4H24VUAGKDQO5CKBANCNFSM4JBNK72Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2K7U37XAVI2565B63QO5CKBA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFU2BY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications\u0026email_token=AFTOJK45L6ETFZ33NLTHRZ3QO5CKBA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFU2BY#pullrequestreview-302730503",
"url": "https://github.com/quicwg/base-drafts/pull/3098?email_source=notifications\u0026email_token=AFTOJK45L6ETFZ33NLTHRZ3QO5CKBA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIFU2BY#pullrequestreview-302730503",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5da74d202f5f7_53913fb6f08cd96c18248b--