Re: [quicwg/base-drafts] Refine Discussion of 0-RTT Transport Parameters (#2467)

Martin Thomson <notifications@github.com> Sun, 17 February 2019 20:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C0281128CB7 for <quic-issues@ietfa.amsl.com>; Sun, 17 Feb 2019 12:18:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kVGFkwAE2BDO for <quic-issues@ietfa.amsl.com>; Sun, 17 Feb 2019 12:18:23 -0800 (PST)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E8410126C7E for <quic-issues@ietf.org>; Sun, 17 Feb 2019 12:18:22 -0800 (PST)
Date: Sun, 17 Feb 2019 12:18:21 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550434701; bh=zQtLq8VT3rBJw86P59L0YeONEXuZIPnIXtmGdKSA27A=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wFJV0wP1RuiQpFUl+2fViPl8iOiBNaDQ5iw54QR8J7aFd4OD1IrMZdYbOvXb4XPZ1 wzkzw4hxxqHOWoKgzWQxTaGkO1mv1rkCOH0A9y/cfW2HCbrRxBaGY5tXOe3yD6MGxC CWSKCXhejpWJD/OV4rXZX1CMdIgAivDf0lgwsAXw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0dbaa1c327d293a8be4b1720e18e18d0f664a90692cf000000011881838d92a169ce187830aa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2467/review/204578050@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2467@github.com>
References: <quicwg/base-drafts/pull/2467@github.com>
Subject: Re: [quicwg/base-drafts] Refine Discussion of 0-RTT Transport Parameters (#2467)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c69c18dbdef5_59433fa6caed45bc141776e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QWqbgxsE-SBUkE30Zf7lSkRlmvw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Feb 2019 20:18:26 -0000

martinthomson commented on this pull request.

A few suggestions, but I like this.  Maybe I will do the tabulation thing later.

> -when accepting 0-RTT data.  A server uses the transport parameters in
-determining whether to accept 0-RTT data.
-
-A server MAY accept 0-RTT and subsequently provide different values for
-transport parameters for use in the new connection.  If 0-RTT data is accepted
-by the server, the server MUST NOT reduce any limits or alter any values that
-might be violated by the client with its 0-RTT data.  In particular, a server
-that accepts 0-RTT data MUST NOT set values for the following parameters
-({{transport-parameter-definitions}}) that are smaller
-than the remembered value of those parameters.
+Clients remember the value of transport parameters from a server and apply
+them to any 0-RTT packets that are sent in subsequent connections, except
+for transport parameters that are explicitly excluded. Remembered transport
+parameters apply to the new connection until the handshake completes and the
+client starts sending 1-RTT packets. Once the handshake completes, the client
+uses the transport parameters established in thehandshake.

```suggestion
uses the transport parameters established in the handshake.
```

> -than the remembered value of those parameters.
+Clients remember the value of transport parameters from a server and apply
+them to any 0-RTT packets that are sent in subsequent connections, except
+for transport parameters that are explicitly excluded. Remembered transport
+parameters apply to the new connection until the handshake completes and the
+client starts sending 1-RTT packets. Once the handshake completes, the client
+uses the transport parameters established in thehandshake.
+
+The value of the server's previous original_connection_id, preferred_address,
+stateless_reset_token, and ack_delay_exponent MUST NOT be used when
+establishing a new connection; rather, the client should wait to observe the
+server's new values in the handshake. If the server does not provide a new
+value, the client MUST use the default value.
+
+The client MAY store the server's original max_packet_size transport
+parameter.

```suggestion
```

> -({{transport-parameter-definitions}}) that are smaller
-than the remembered value of those parameters.
+Clients remember the value of transport parameters from a server and apply
+them to any 0-RTT packets that are sent in subsequent connections, except
+for transport parameters that are explicitly excluded. Remembered transport
+parameters apply to the new connection until the handshake completes and the
+client starts sending 1-RTT packets. Once the handshake completes, the client
+uses the transport parameters established in thehandshake.
+
+The value of the server's previous original_connection_id, preferred_address,
+stateless_reset_token, and ack_delay_exponent MUST NOT be used when
+establishing a new connection; rather, the client should wait to observe the
+server's new values in the handshake. If the server does not provide a new
+value, the client MUST use the default value.
+
+The client MAY store the server's original max_packet_size transport

```suggestion
```

> +
+The definition of new transport parameters ({{new-transport-parameters}}) MUST
+specify whether they MUST, MAY, or MUST NOT be stored for 0-RTT. A client need
+not store a transport parameter it cannot process.
+
+A client that attempts to send 0-RTT data MUST remember all other transport
+parameters used by the server. The server can remember these transport
+parameters, or store an integrity-protected copy of the values in the ticket
+and recover the information when accepting 0-RTT data. A server uses the
+transport parameters in determining whether to accept 0-RTT data.
+
+If 0-RTT data is accepted by the server, the server MUST NOT reduce any
+limits or alter any values that might be violated by the client with its
+0-RTT data.  In particular, a server that accepts 0-RTT data MUST NOT set
+values for the following parameters ({{transport-parameter-definitions}})
+that are smaller than the remembered value of those parameters.

```suggestion
that are smaller than the remembered value of those parameters:
```

> -
-A server MAY accept 0-RTT and subsequently provide different values for
-transport parameters for use in the new connection.  If 0-RTT data is accepted
-by the server, the server MUST NOT reduce any limits or alter any values that
-might be violated by the client with its 0-RTT data.  In particular, a server
-that accepts 0-RTT data MUST NOT set values for the following parameters
-({{transport-parameter-definitions}}) that are smaller
-than the remembered value of those parameters.
+Clients remember the value of transport parameters from a server and apply
+them to any 0-RTT packets that are sent in subsequent connections, except
+for transport parameters that are explicitly excluded. Remembered transport
+parameters apply to the new connection until the handshake completes and the
+client starts sending 1-RTT packets. Once the handshake completes, the client
+uses the transport parameters established in thehandshake.
+
+The value of the server's previous original_connection_id, preferred_address,

I think that maybe this paragraph can be moved after the one starting with "The definition of"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2467#pullrequestreview-204578050