Re: [quicwg/base-drafts] Size limit for Version Negotiation (#754)
Mike Bishop <notifications@github.com> Wed, 06 September 2017 22:51 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EAD6A132D14 for <quic-issues@ietfa.amsl.com>; Wed, 6 Sep 2017 15:51:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.596
X-Spam-Level:
X-Spam-Status: No, score=-5.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ysm_k9GAZo6c for <quic-issues@ietfa.amsl.com>; Wed, 6 Sep 2017 15:51:22 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext7.iad.github.net [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 698A012EC30 for <quic-issues@ietf.org>; Wed, 6 Sep 2017 15:51:22 -0700 (PDT)
Date: Wed, 06 Sep 2017 15:51:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1504738281; bh=x41HTz4h/2pEPCWDaYXoQEKi3WSlWgwfocicZ3BzVf8=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aoN1hbIcRzDwCtcOsN+razptGbIvjXwW89nGY8hT9ZJXFZdH8K55sP3S3AjsMvCbs yjY2cQr7qwHmJpfRfAQvWzpLJmnkAvdmH0p1NwCcqV942G0+HWeAhoxjUQcbpy+SHW rWUtQUR3MKNKee3jbqgcRwYP+Y/MvBnQmzA4LUKQ=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbd38db3da3379e77fded1c75a4040153606692f392cf0000000115c83de992a169ce0f26f72c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/754/review/61072847@github.com>
In-Reply-To: <quicwg/base-drafts/pull/754@github.com>
References: <quicwg/base-drafts/pull/754@github.com>
Subject: Re: [quicwg/base-drafts] Size limit for Version Negotiation (#754)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59b07be9875bf_cfe3fdb8891bc2c860fa"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QXAcrMAbZ9BtstfIIe6KTgeXj2c>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Sep 2017 22:51:24 -0000
MikeBishop approved this pull request.
SGTM.
> @@ -887,6 +887,13 @@ server discards the incoming packet and responds with a Version Negotiation
packet ({{packet-version}}). This includes a list of versions that the server
will accept.
+There is no limit to the size of the Version Negotiation packet, other than the
+number of versions that the server supports and the estimated path MTU. To
Since the point of this change is to impose a limit, this first sentence seems contradictory. I'd just drop it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/754#pullrequestreview-61072847
- [quicwg/base-drafts] Size limit for Version Negot… Martin Thomson
- Re: [quicwg/base-drafts] Size limit for Version N… Mike Bishop
- Re: [quicwg/base-drafts] Size limit for Version N… Martin Thomson
- Re: [quicwg/base-drafts] Size limit for Version N… Martin Thomson
- Re: [quicwg/base-drafts] Size limit for Version N… janaiyengar