Date: Wed, 06 Sep 2017 15:51:21 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abbd38db3da3379e77fded1c75a4040153606692f392cf0000000115c83de992a169ce0f26f72c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/754/review/61072847@github.com>
In-Reply-To: <quicwg/base-drafts/pull/754@github.com>
References: <quicwg/base-drafts/pull/754@github.com>
Subject: Re: [quicwg/base-drafts] Size limit for Version Negotiation (#754)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_59b07be9875bf_cfe3fdb8891bc2c860fa";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QXAcrMAbZ9BtstfIIe6KTgeXj2c>


----==_mimepart_59b07be9875bf_cfe3fdb8891bc2c860fa
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

MikeBishop approved this pull request.

SGTM.

> @@ -887,6 +887,13 @@ server discards the incoming packet and responds with a Version Negotiation
 packet ({{packet-version}}).  This includes a list of versions that the server
 will accept.
 
+There is no limit to the size of the Version Negotiation packet, other than the
+number of versions that the server supports and the estimated path MTU.  To

Since the point of this change is to impose a limit, this first sentence seems contradictory.  I'd just drop it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/754#pullrequestreview-61072847
----==_mimepart_59b07be9875bf_cfe3fdb8891bc2c860fa
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@MikeBishop</b> approved this pull request.</p>

<p>SGTM.</p><hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/754#discussion_r137410102">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -887,6 +887,13 @@ server discards the incoming packet and responds with a Version Negotiation
 packet ({{packet-version}}).  This includes a list of versions that the server
 will accept.
 
+There is no limit to the size of the Version Negotiation packet, other than the
+number of versions that the server supports and the estimated path MTU.  To
</pre>
<p>Since the point of this change is to impose a limit, this first sentence seems contradictory.  I'd just drop it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/754#pullrequestreview-61072847">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq-edgU2Yv1F1ZhD_VUWn0DcJ7aT4ks5sfyHpgaJpZM4PIToK">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AWbkqwnA3gV2luvcrRfWNFkS7HX3nDxFks5sfyHpgaJpZM4PIToK.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/quicwg/base-drafts/pull/754#pullrequestreview-61072847"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MikeBishop approved #754"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/754#pullrequestreview-61072847"}}}</script>
----==_mimepart_59b07be9875bf_cfe3fdb8891bc2c860fa--