Re: [quicwg/base-drafts] Implicit acknowledgment via header block acknowledgment (#1399)
afrind <notifications@github.com> Thu, 14 June 2018 00:23 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 85300130EC8 for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 17:23:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SvITIIiic6nl for <quic-issues@ietfa.amsl.com>; Wed, 13 Jun 2018 17:23:16 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16E38130EBD for <quic-issues@ietf.org>; Wed, 13 Jun 2018 17:23:16 -0700 (PDT)
Date: Wed, 13 Jun 2018 17:23:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528935794; bh=y3t6XQpmY8MzCgSLCqr/DFmYjhqupJX9yWFZ/zo0nK8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=IoMQaUuCfO8k/8tjGzEJ5akFDnxq5ts1Pq0iyBEtsGWy1fX1BU7SukIJvzoQ29el1 xxsq+ARVTF90Vi+/0IkxIf9LDuYbPrezOIO6byec3x3o3LOi02S/g1DAWDCYFyJUiA GSL3/iU/+fIk9XYOEqYMSSdh7qXuSjUOWLlUekYQ=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe2f5d61fa9a4e03ea56d4ddce13684a6d0d793a292cf000000011739777292a169ce13860808@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1399/review/128607377@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1399@github.com>
References: <quicwg/base-drafts/pull/1399@github.com>
Subject: Re: [quicwg/base-drafts] Implicit acknowledgment via header block acknowledgment (#1399)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b21b572c66a0_66ae2ab4e5cccf5854542"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Qd8VgLRRjmL-AmRdHGRxf1t_enE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 00:23:18 -0000
afrind commented on this pull request. > @@ -523,6 +532,16 @@ blocks within a stream have been fully processed. ~~~~~~~~~~ {:#fig-header-ack title="Header Acknowledgement"} +An encoder MUST treat receipt of a Header Acknowledgment as also acknowledging +any dynamic table entries that the header block referenced. That is, this +instruction is also processed as a Table Size Synchronize instruction with a Table *State* Synchronize. It's wrong in the figure from that section also. > @@ -489,9 +489,18 @@ After processing a set of instructions on the encoder stream, the decoder will emit a Table State Synchronize instruction on the decoder stream. The instruction begins with the '1' one-bit pattern. The instruction specifies the total number of dynamic table inserts and duplications since the last Table -State Synchronize, encoded as a 7-bit prefix integer. The encoder uses this -value to determine which table entries are vulnerable to head-of-line blocking. -A decoder MAY coalesce multiple synchronization updates into a single update. +State Synchronize or Header Acknowledgement that increased the largest Reading the section here makes me think perhaps having Header Acknowledgement described before TSS. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1399#pullrequestreview-128607377
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- [quicwg/base-drafts] Implicit acknowledgment via … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson