Re: [quicwg/base-drafts] Python linting script (#1032)

Martin Thomson <notifications@github.com> Thu, 04 January 2018 00:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DB1F912D7FC for <quic-issues@ietfa.amsl.com>; Wed, 3 Jan 2018 16:06:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.595
X-Spam-Level:
X-Spam-Status: No, score=-5.595 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZlrFA71MOjEh for <quic-issues@ietfa.amsl.com>; Wed, 3 Jan 2018 16:06:58 -0800 (PST)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext3.iad.github.net [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39427126BF6 for <quic-issues@ietf.org>; Wed, 3 Jan 2018 16:06:58 -0800 (PST)
Date: Wed, 03 Jan 2018 16:06:57 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1515024417; bh=JzoYRS7v+TKcqRX4vZx/kqTFemutBK3FmCf27etMNe4=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ki/Db+iCcfpAk7uzQ+yC7lAA77fMsfkXRywMfKM//QHmaYEgXrAQVFZD1RQi1Fi/l A1iJe7GTwMaqiraaco4syPFWreS0b8l8s0Vt9gjW1F2GNOX1r1J8e01ZO5mfTQUOyG GHafew2hlTKUTmwc0m3rX8pK+mwZSB4SKOLJ0luE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3f9dd1ffde2b80ff98170dd47cfb668edbdf562892cf000000011665322192a169ce10f35235@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1032/c355163158@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1032@github.com>
References: <quicwg/base-drafts/pull/1032@github.com>
Subject: Re: [quicwg/base-drafts] Python linting script (#1032)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a4d702191b36_69113f9efaca8f2c9532a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QeA--un7GbyqhLYEXusY29RFjRM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jan 2018 00:07:00 -0000

OK, this seems good.  A modest improvement on linux.  I'm going to autopep8 this and drop the extra comma.

```
$ git co pylint
$ time make lint

real    0m0.691s
user    0m0.395s
sys     0m0.355s
$ git co master
$ time make lint

real    0m1.008s
user    0m0.588s
sys     0m0.544s
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1032#issuecomment-355163158