Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)

Kazuho Oku <notifications@github.com> Wed, 16 January 2019 11:57 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9DADE12F18C for <quic-issues@ietfa.amsl.com>; Wed, 16 Jan 2019 03:57:35 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.551
X-Spam-Level:
X-Spam-Status: No, score=-7.551 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2t-Jfwf0d9L6 for <quic-issues@ietfa.amsl.com>; Wed, 16 Jan 2019 03:57:34 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D127C128B01 for <quic-issues@ietf.org>; Wed, 16 Jan 2019 03:57:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=qH+FDvlrwDaM4ajgWvP7E+bLb2Y=; b=krnptdB6hzvkATaj x0tjubFyMvHnguF0FAua6/4XJXm0rifGN39YDTltzieh/3ikvx07DlrMfEISkviI N6ZBjq70yY4S0rNNVFDqRB5oq5G9QdlL6YgjdCMKJYg61JfxlWpjuslSiFSq4Uem If67umcK1Pq4j6hMudJlAGy2S4E=
Received: by filter0060p1iad2.sendgrid.net with SMTP id filter0060p1iad2-912-5C3F1C2C-13 2019-01-16 11:57:32.47896479 +0000 UTC m=+134172.997824751
Received: from github-lowworker-e711880.cp1-iad.github.net (unknown [192.30.252.45]) by ismtpd0003p1iad2.sendgrid.net (SG) with ESMTP id VrLcuwC0ShqfTBT_7POatw for <quic-issues@ietf.org>; Wed, 16 Jan 2019 11:57:32.532 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e711880.cp1-iad.github.net (Postfix) with ESMTP id 7F259440DE7 for <quic-issues@ietf.org>; Wed, 16 Jan 2019 03:57:32 -0800 (PST)
Date: Wed, 16 Jan 2019 11:57:32 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab49812b29deb03a8fd46cb34fc314ee78012905a892cf000000011856de2c92a169ce17b2473c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2327/review/193100097@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2327@github.com>
References: <quicwg/base-drafts/pull/2327@github.com>
Subject: Re: [quicwg/base-drafts] Ignore packet loss when the keys are not available (#2327)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3f1c2c7cd9a_438f3fb69a8d45c417019f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3BVMAjWBm4TWwCBs1u4ezOmpBJFywFGlBhL1 HCWuvk56FcwXqCo+naa6JS+jh8/2YU+KA2HGwWq9uN4Nos2s95pVwMBXUxn2kdk51cTwteCLNlMCNn Q0ZHp1NANb0lf0JAZfEhUduVCro3SO3Z+GsPhjJE3NifS+TFF9M+LP1C8uA635ZaYZxWuXLuD+W0gy k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QhD9yxnAbiT2eyiOy3HVXeeJNNY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2019 11:57:36 -0000

kazuho commented on this pull request.



> @@ -427,15 +445,34 @@ packet is received.  The client MAY use this value to seed the RTT estimator for
 a subsequent connection attempt to the server.
 
 
-#### Discarding Initial State {#discard-initial}
+#### Discarding Keys and Packet State {#discarding-packets}
+
+When packet protection keys are discarded (see Section 4.9 of {{QUIC-TLS}}),
+recovery state for all in-flight packets sent with those keys is discarded.
+The packets are removed from the count of bytes in flight and no
+acknowledgements or loss events will occur for those packets.  Note that it
+is expected that keys are discarded after those packets would be declared lost,
+but Initial secrets are destroyed earlier.

IIUC this refers to the provision in https://quicwg.org/base-drafts/draft-ietf-quic-tls.html#rfc.section.4.10. Maybe it's worth adding a reference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2327#discussion_r248253477