Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Marten Seemann <notifications@github.com> Fri, 05 April 2019 14:37 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F2B86120453 for <quic-issues@ietfa.amsl.com>; Fri, 5 Apr 2019 07:37:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mk2N7N5AHw16 for <quic-issues@ietfa.amsl.com>; Fri, 5 Apr 2019 07:37:52 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7E73E12044F for <quic-issues@ietf.org>; Fri, 5 Apr 2019 07:37:52 -0700 (PDT)
Date: Fri, 05 Apr 2019 07:37:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554475071; bh=t3kVQsLMbhA4bDjDoe6kaHQNhWpHlW2ZcnOVF2QGeNY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=NteGLbklqgNKKPTTpDv1PA5tAKzhm+9bhc4vzBc8hfYynw4x9FsnYgRpmznDKyo1o 172Pn0BTymZsHwXSB+PTpizvTbEiofTtYHUqHb5CH5gA9HK4qLcQYRD0V/xqu0ky94 Yb+hLY3y2OjWH0CRS+igDOSiMxcOfjljT/mOCmRc=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab498efdf11fe3ff2f1af3c33976055c5975338f1d92cf0000000118bf2a3f92a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/review/223312136@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ca7683f4f0e6_625b3fab608d45b445664"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/QhdGq4kawCfkjVrSz-XFsCrsDiY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Apr 2019 14:37:54 -0000
marten-seemann commented on this pull request. > @@ -458,11 +458,11 @@ sent, then no alarm should be armed until data has been received from the client. Because the server could be blocked until more packets are received, the client -MUST start the crypto retransmission timer even if there is no unacknowledged -CRYPTO data. If the timer expires and the client has no CRYPTO data to -retransmit and does not have Handshake keys, it SHOULD send an Initial packet in -a UDP datagram of at least 1200 bytes. If the client has Handshake keys, it -SHOULD send a Handshake packet. +MUST start the crypto retransmission timer until it has 1RTT keys, even if there You're right, but it's kind of hard to understand. What about the following structure: "MUST start the crypto retransmission timer if there is outstanding CRYPTO data. It MUST also start the crypto retransmission timer until it has 1-RTT keys,..." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2590#discussion_r272616981
- [quicwg/base-drafts] Don't arm the handshake time… ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … Marten Seemann
- Re: [quicwg/base-drafts] Don't arm the handshake … martinduke
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Benjamin Saunders
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … ianswett
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar
- Re: [quicwg/base-drafts] Don't arm the handshake … Jana Iyengar