Date: Tue, 21 Jul 2020 17:50:27 -0700
From: Praveen Balasubramanian <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5MTXS6AYQYRCVIV4F5ENXFHEVBNHHCPCKV2M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3929/review/452923097@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3929@github.com>
References: <quicwg/base-drafts/pull/3929@github.com>
Subject: Re: [quicwg/base-drafts] Use better example for persistent congestion
 (#3929)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5f178d53252ba_e3d3fc052ecd96439318";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/R5UlvRwzYrOw7fqCZEMWWji3nHg>


----==_mimepart_5f178d53252ba_e3d3fc052ecd96439318
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@pravb commented on this pull request.



> +| t=3   | Send packet #4 (app data)  |
+| t=4   | Send packet #5 (app data)  |
+| t=5   | Send packet #6 (app data)  |
+| t=6.5 | Send packet #7 (PTO 1)     |
+| t=9.5 | Send packet #8 (PTO 2)     |
+| t=9.7 | Recv acknowledgement of #8 |
+
+Packets 2 through 7 are declared lost when the acknowledgement for packet 8 is
+received at t = 9.7.
+
+The congestion period is calculated as the time between the oldest and newest
+lost packets: 6.5 - 1 = 5.5.  The duration for establishing persistent
+congestion is: 1.5 * 3 = 4.5.  Because the threshold was reached and because
+none of the packets between the oldest and the newest lost packets were
+acknowledged, the network is considered to have experienced persistent
+congestion.

I think we should still add a line here about PTO not being necessary for establishing persistent congestion since the example still uses PTO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3929#pullrequestreview-452923097
----==_mimepart_5f178d53252ba_e3d3fc052ecd96439318
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@pravb</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3929#discussion_r458470264">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; +| t=3   | Send packet #4 (app data)  |
+| t=4   | Send packet #5 (app data)  |
+| t=5   | Send packet #6 (app data)  |
+| t=6.5 | Send packet #7 (PTO 1)     |
+| t=9.5 | Send packet #8 (PTO 2)     |
+| t=9.7 | Recv acknowledgement of #8 |
+
+Packets 2 through 7 are declared lost when the acknowledgement for packet 8 is
+received at t = 9.7.
+
+The congestion period is calculated as the time between the oldest and newest
+lost packets: 6.5 - 1 = 5.5.  The duration for establishing persistent
+congestion is: 1.5 * 3 = 4.5.  Because the threshold was reached and because
+none of the packets between the oldest and the newest lost packets were
+acknowledged, the network is considered to have experienced persistent
+congestion.
</pre>
<p>I think we should still add a line here about PTO not being necessary for establishing persistent congestion since the example still uses PTO.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3929#pullrequestreview-452923097">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK4FUDPPUNXL76GG4WLR4YZVHANCNFSM4PEBXL7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZXLFN6HXOHDEIE7V3R4YZVHA5CNFSM4PEBXL72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODL7Q5WI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3929#pullrequestreview-452923097",
"url": "https://github.com/quicwg/base-drafts/pull/3929#pullrequestreview-452923097",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5f178d53252ba_e3d3fc052ecd96439318--