Re: [quicwg/base-drafts] Don't let the PMTU drop below 1280 (#2069)
Marten Seemann <notifications@github.com> Thu, 29 November 2018 04:01 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF4EF12F1A5 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 20:01:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GkfgYTO669M0 for <quic-issues@ietfa.amsl.com>; Wed, 28 Nov 2018 20:01:11 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0E56C12777C for <quic-issues@ietf.org>; Wed, 28 Nov 2018 20:01:11 -0800 (PST)
Date: Wed, 28 Nov 2018 20:01:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543464070; bh=gtrGrvo8W0JcrFGagiNj7ezc5YHU1ZUXxQl9ApI/Vn0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Dk+ex638RPvtXr+dktRwPQPT6seXdZOBuaqsw9WS+Uwhr5Xa6JH9DqdGE/pzFrpiM XgNXdnXTUJgYLF+C25/7XD1cySg/Z/p74K/pHCY6lO47NB/lNvQGdj/slCJlGSg/m6 LYS7FtfjPoqWBiTwRbqmEdXzX96oKZne443/xjKo=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab467d56efc9b0ee998db384d288658ca62aebe83592cf000000011817268692a169ce16fb2d96@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2069/review/179621200@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2069@github.com>
References: <quicwg/base-drafts/pull/2069@github.com>
Subject: Re: [quicwg/base-drafts] Don't let the PMTU drop below 1280 (#2069)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bff64864adcf_47503fc1cbad45b81421ba"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/R64FsPELq1P8oPvSF-M5jDheIvE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2018 04:01:13 -0000
marten-seemann commented on this pull request. > @@ -3100,9 +3100,11 @@ Further validation can also be provided: use for validation (for example, the IP ID or UDP checksum). The endpoint SHOULD ignore all ICMP messages that are not validated or do not -carry sufficient quoted packet payload to perform validation. Any reduction in -the QUIC maximum packet size MAY be provisional until QUIC's loss detection -algorithm determines that the quoted packet has actually been lost. +carry sufficient quoted packet payload to perform validation. ICMP messages +that suggest that the PMTU has decreased below 1280 bytes SHOULD also be Why only a SHOULD? We say that QUIC depends on a PMTU of at least 1280 bytes, so I think a MUST would be justified here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2069#pullrequestreview-179621200
- [quicwg/base-drafts] Don't let the PMTU drop belo… Martin Thomson
- Re: [quicwg/base-drafts] Don't let the PMTU drop … Marten Seemann
- Re: [quicwg/base-drafts] Don't let the PMTU drop … Martin Thomson
- Re: [quicwg/base-drafts] Don't let the PMTU drop … Marten Seemann
- Re: [quicwg/base-drafts] Don't let the PMTU drop … ianswett
- Re: [quicwg/base-drafts] Don't let the PMTU drop … Martin Thomson