Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)

ianswett <notifications@github.com> Thu, 24 October 2019 23:51 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 85760120090 for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 16:51:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwqivsyRAdoC for <quic-issues@ietfa.amsl.com>; Thu, 24 Oct 2019 16:51:07 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0D16D120019 for <quic-issues@ietf.org>; Thu, 24 Oct 2019 16:51:06 -0700 (PDT)
Date: Thu, 24 Oct 2019 16:51:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571961066; bh=OzPXmSm0z/Q7zKz02wzwg+YOojmQg/wpiKPYFEheycI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=j/dSxtgy1z3954H2pm51ViZP2n9rAGCMj3Vk53ZjOuerPjV7BpElHeGlsCDBBh8U1 oh117TUsL7BF1Xh+b5poiazIBevALeLnZ31I9RRcsuzA44NAP/e4dn3G352NGrS7PH 7rQf99HkEvCFs52h3rNhWWJJTnpIrPRFza5/tdhk=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7EING3AHDZDSA4JMV3X54XVEVBNHHB2737AM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3047/review/306922292@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3047@github.com>
References: <quicwg/base-drafts/pull/3047@github.com>
Subject: Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db238ea32bd8_7b423ffc7e0cd9646166f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/R8FVTHvLBHfANUY8aehhu5oLQkE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Oct 2019 23:51:09 -0000

ianswett commented on this pull request.



> @@ -1031,9 +1031,8 @@ OnAckReceived(ack, pn_space):
     OnPacketAcked(acked_packet.packet_number, pn_space)
 
   DetectLostPackets(pn_space)

Q: Why would you always send one packet?  Depending on how ACKs were grouped, this could result in an unnecessary burst of packets that could defeat the congestion controller's intent.  Based on my experience, I don't think this is a purely theoretical problem.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3047#discussion_r338837625