[quicwg/base-drafts] Invalid CONNECTION_CLOSE frames (#2475)

martinduke <notifications@github.com> Fri, 15 February 2019 17:47 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B1C2131021 for <quic-issues@ietfa.amsl.com>; Fri, 15 Feb 2019 09:47:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q1eZ8lx-MDtO for <quic-issues@ietfa.amsl.com>; Fri, 15 Feb 2019 09:47:10 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16E84130FD6 for <quic-issues@ietf.org>; Fri, 15 Feb 2019 09:47:01 -0800 (PST)
Date: Fri, 15 Feb 2019 09:46:59 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550252819; bh=7CZtatU1Rwq8EbtsdqxTCx2CpcThQug0bvGwKVdibPY=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=egEP3SzquXLHJrNKyM4CH+YFP+N/SFwY3TC026D1a8Vts4ogVIDxd4HkJygbqCNO8 xzkawTs3NAW1PY6QlURmgUO11dBYlw6VLWiWvdk0oBU9bhK9vlf6JW55cB4VDoI23a WsBqPbOQcttzjSLtYWKQY3/ixoUsbGwlKiRbn86c=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abce802d20a9b622a5c0a997bb5daa6f06cd93f5de92cf00000001187ebd1392a169ce187d7b4d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2475@github.com>
Subject: [quicwg/base-drafts] Invalid CONNECTION_CLOSE frames (#2475)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c66fb13bfa3b_6ece3fa0fcad45bc12006"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RNOUzH-y2YEZbrgdPZpWdBOUc3Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2019 17:47:12 -0000

Section 11.1 says:
"An endpoint that receives an invalid CONNECTION_CLOSE frame MUST NOT signal the existence of the error to its peer."

Editorially, it is not clear to me whether I am to suppress the error code in the CONNECTION_CLOSE frame or the error I generate when I receive an invalid frame.

Moreover, I am not sure what constitutes an invalid CONNECTION_CLOSE frame. The words don't occur elsewhere. Section 19.19 doesn't define any fatal errors for this type. I can imagine a Reason Length that overruns the packet, or perhaps an undefined error code? A bogus frame type? We should probably define those in 19.19.

Perhaps this sentence is an artifact from before we were throwing away Initial keys agressively?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2475