Re: [quicwg/base-drafts] Avoid renewing retired connection IDs (#1799)

erickinnear <notifications@github.com> Wed, 26 September 2018 01:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2EA2B130DED for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 18:23:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.456
X-Spam-Level:
X-Spam-Status: No, score=-8.456 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.456, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qQXQFE8YFoTS for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 18:23:18 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 707A3130DFF for <quic-issues@ietf.org>; Tue, 25 Sep 2018 18:23:18 -0700 (PDT)
Date: Tue, 25 Sep 2018 18:23:17 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537924997; bh=p8v0oGXLDx1yHPGQywoTfC7txmpTgfP7HD+P1Pj6RMg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=r9IsgcIY84owJRL0wfrV6nNovPvFyJn/Lk6PQKZJPUXD+H9GlmXKJEssHZ8Y+1U+T vuwusDJFCf5GnEWKWTqXyiDUQ1dDl5dmHovXA/AdIwoJ2s22jvSg1I05u6cWyRsqjP +4AOj7ymLWm5GSbbYnDGaZVQtSIJVUxkN8bvE3No=
From: erickinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab35775d8dbb9e7c78d882a52d0a38f2f51f9aaf4c92cf0000000117c2a18592a169ce15af01d9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1799/424553366@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1799@github.com>
References: <quicwg/base-drafts/issues/1799@github.com>
Subject: Re: [quicwg/base-drafts] Avoid renewing retired connection IDs (#1799)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baadf855af3f_3d543f91370d45b41376b2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RNURo7V41b6Dcw7E3kheWcJYGPg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 01:23:20 -0000

If you're going to use the proposal from NYC: 

> Each CID comes with a sequence number, every CID that you send must have a sequence number higher than any you've previously sent

> This does not requiring anything to happen in lockstep as before, however this solves a big edge case in that you can now forget CIDs immediately instead of waiting for 3xRTO when you retire them, since any NEW_CONNECTION_ID frame crossing paths with the retirement frame will contain a sequence number. Instead, you just remember the highest sequence number NEW_CONNECTION_ID that you've RETIRED.

>For example:
Peer sends NEW_CONNECTION_ID and you use it, then immediately retire it with RETIRE_CONNECTION_ID.
Ack of NEW_CONNECTION_ID gets lost.
RETIRE_CONNECTION_ID frame is still in flight when the peer retransmits NEW_CONNECTION_ID.
If you've got a sequence number you can keep track of the highest sequence that you've gotten and, since this one will not advance the sequence number, you can safely ignore the duplicate NEW_CONNECTION_ID frame.

Note the distinction between *received* and *retired* sequence number, since if you keep track of *received* sequence number for dropping new ones, then reordering between NEW_CONNECTION_ID frames can cause you to ignore some of them when you shouldn't. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1799#issuecomment-424553366