Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)

afrind <notifications@github.com> Wed, 20 March 2019 22:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D39A213125E for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 15:56:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gljQYIOBQi7r for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 15:56:36 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 202B7131225 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 15:56:36 -0700 (PDT)
Date: Wed, 20 Mar 2019 15:56:34 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553122594; bh=axkuAg98+RPISz/x3MqZphfzUbZCMN/7GyiJsr60dow=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0BVsXppp39Tt6Etw/klBOH1UDxDqtbcIp4dj47JhsRxrGaVqzmf60vqZ34Ff9U/Ir 9A5kQ9wXkHK1sZUuqYFBrrEmPwmzT+MPDp6K6g0weCxHhGZLt+dwICqXgnpRXxa6zx FRQYP3xG9qCtlYfVf3eD/AZa8sPGPRQ27tbQb1aw=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab70389db64958a341a06c18d533c80560c922a10492cf0000000118aa872292a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/217022319@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c92c522d5f9f_56083fe62f8d45b4582420"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ROdmzqLNw16FgD7J-sKlwNuhfQM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 22:56:38 -0000

afrind commented on this pull request.



>  HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either
 unidirectional stream type MUST be treated as a connection error of type
 HTTP_CLOSED_CRITICAL_STREAM.
 
+An endpoint MAY avoid creating its own encoder stream if the maximum size of
+the dynamic table permitted by the peer is zero.
+
+An endpoint MAY avoid creating its own decoder stream if the maximum size of
+its own dynamic table is zero.
+
+An endpoint MUST allow its peer to create both encoder and decoder streams

@dtikhonov : I mean to say, that an implementation that prevents the creation of QPACK streams is not conformant, in the same way it would not be conformant to set it to 0 and block the creation of the control stream.  This is my understanding of the consensus based on the last discussion in Toyko.

@LPardue : I'm not sure that's such a big deal.  If you planned to use the dynamic table, but wasted your stream on grease instead of an encoder stream, then you can't use the table.  If you disabled the dynamic table for your peer, then you don't need to create the decoder stream anyways.  If you allowed the peer to use the dynamic table but can't create a decoder stream, then your compression will eventually degrade to ~static only but I think the connection will still work. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2529#discussion_r267578761