Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 32271131258 for ; Tue, 18 Dec 2018 15:23:54 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -6.387 X-Spam-Level: X-Spam-Status: No, score=-6.387 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FUZZY_CREDIT=1.678, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7VtvbRpoi1C for ; Tue, 18 Dec 2018 15:23:52 -0800 (PST) Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 010B0131257 for ; Tue, 18 Dec 2018 15:23:52 -0800 (PST) Date: Tue, 18 Dec 2018 15:23:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545175431; bh=yuSwzuVbk/1SW9gYmXGRcWEH/StXn3BwoUPNdwb8YWY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=D+3rpzNr4X0zG0JS+ElL/4reUEfX1uFxwiZE++N4IZRudXooiTtrfM3PEhzejYXrt 4g1KMJPPtTAByWlenStFiX9Z9c6+22l/QKtz5znmuvKt0s1+NgnL4PjfTStXbb7eUC 4EWeX5k/pV/+LkdNgRGVxL1MAz6kIEpe+ZcaZskA= From: Mike Bishop Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Ekr editorial 17 http (#2204) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5c19818715309_506f3f9d406d45bc12826d"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: MikeBishop X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 23:23:54 -0000 ----==_mimepart_5c19818715309_506f3f9d406d45bc12826d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit MikeBishop requested changes on this pull request. Mostly good, but some minor nits. Is it possible not to rewrap things to a smaller size? Otherwise, I'll go through and rewrap before merging. > @@ -324,7 +325,7 @@ transport parameter `initial_max_uni_streams`. If the stream header indicates a stream type which is not supported by the recipient, the remainder of the stream cannot be consumed as the semantics are -unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING +unknown. Recipients of unknown stream types MAY send a QUIC STOP_SENDING The use of "trigger" is deliberate, since an HTTP implementation cannot directly send transport frames. It can ask the transport implementation to do so. > @@ -546,14 +548,16 @@ the interpretation of the associated Element ID fields. | 10 | Placeholder | Placeholder ID | | 11 | Root of the tree | Absent | -Note that the root of the tree cannot be referenced using a Stream ID of 0, as -in {{!RFC7540}}; QUIC stream 0 carries a valid HTTP request. The root of the -tree cannot be reprioritized. A PRIORITY frame sent on a request stream with the -Prioritized Element Type set to any value other than `11` or which expresses a -dependency on a request with a greater Stream ID than the current stream MUST be -treated as a stream error of type HTTP_MALFORMED_FRAME. Likewise, a PRIORITY -frame sent on a control stream with the Prioritized Element Type set to `11` -MUST be treated as a connection error of type HTTP_MALFORMED_FRAME. +Note that unlike in {{!RFC7540}}; the root of the tree cannot be I don't think this should be a semicolon. > @@ -312,7 +312,7 @@ permit the encoder to track the decoder's state. These events are: - Complete processing of a header block - Abandonment of a stream which might have remaining header blocks -- Receipt of new dynamic table entries +- Receipt of new dynamic table entries (Table State Synchronize) Why specify the instruction for this event, but not for the others? This ought to be consistent. > @@ -375,7 +375,7 @@ initial maximum table size is the value of the setting in the peer's SETTINGS frame. Before a new entry is added to the dynamic table, entries are evicted from the -end of the dynamic table until the size of the dynamic table is less than or +end the dynamic table until the size of the dynamic table is less than or "end of" is correct -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2204#pullrequestreview-186326804 ----==_mimepart_5c19818715309_506f3f9d406d45bc12826d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@MikeBishop requested changes on this pull request.

Mostly good, but some minor nits. Is it possible not to rewrap things to a smaller size? Otherwise, I'll go through and rewrap before merging.

In draft-ietf-quic-http.md:

> @@ -324,7 +325,7 @@ transport parameter `initial_max_uni_streams`.
 
 If the stream header indicates a stream type which is not supported by the
 recipient, the remainder of the stream cannot be consumed as the semantics are
-unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING
+unknown. Recipients of unknown stream types MAY send a QUIC STOP_SENDING

The use of "trigger" is deliberate, since an HTTP implementation cannot directly send transport frames. It can ask the transport implementation to do so.

In draft-ietf-quic-http.md:

> @@ -546,14 +548,16 @@ the interpretation of the associated Element ID fields.
 | 10        | Placeholder      | Placeholder ID                 |
 | 11        | Root of the tree | Absent                         |
 
-Note that the root of the tree cannot be referenced using a Stream ID of 0, as
-in {{!RFC7540}}; QUIC stream 0 carries a valid HTTP request.  The root of the
-tree cannot be reprioritized. A PRIORITY frame sent on a request stream with the
-Prioritized Element Type set to any value other than `11` or which expresses a
-dependency on a request with a greater Stream ID than the current stream MUST be
-treated as a stream error of type HTTP_MALFORMED_FRAME.  Likewise, a PRIORITY
-frame sent on a control stream with the Prioritized Element Type set to `11`
-MUST be treated as a connection error of type HTTP_MALFORMED_FRAME.
+Note that unlike in {{!RFC7540}}; the root of the tree cannot be

I don't think this should be a semicolon.

In draft-ietf-quic-qpack.md:

> @@ -312,7 +312,7 @@ permit the encoder to track the decoder's state.  These events are:
 
 - Complete processing of a header block
 - Abandonment of a stream which might have remaining header blocks
-- Receipt of new dynamic table entries
+- Receipt of new dynamic table entries (Table State Synchronize)

Why specify the instruction for this event, but not for the others? This ought to be consistent.

In draft-ietf-quic-qpack.md:

> @@ -375,7 +375,7 @@ initial maximum table size is the value of the setting in the peer's SETTINGS
 frame.
 
 Before a new entry is added to the dynamic table, entries are evicted from the
-end of the dynamic table until the size of the dynamic table is less than or
+end the dynamic table until the size of the dynamic table is less than or

"end of" is correct

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

----==_mimepart_5c19818715309_506f3f9d406d45bc12826d--