[quicwg/base-drafts] Minor fixes for the recovery draft (#3813)

Kazu Yamamoto <notifications@github.com> Thu, 02 July 2020 05:21 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D491D3A0CDC for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 22:21:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PRDJQPPrR70N for <quic-issues@ietfa.amsl.com>; Wed, 1 Jul 2020 22:21:26 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76D3E3A0D08 for <quic-issues@ietf.org>; Wed, 1 Jul 2020 22:21:26 -0700 (PDT)
Received: from github-lowworker-c5134a3.ac4-iad.github.net (github-lowworker-c5134a3.ac4-iad.github.net [10.52.23.55]) by smtp.github.com (Postfix) with ESMTP id 857136A03A9 for <quic-issues@ietf.org>; Wed, 1 Jul 2020 22:21:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1593667285; bh=vZMFkTqdozkTHzL3PBD+qZ+/ulUz6YHFf4sOZ6gupQI=; h=Date:From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post: List-Unsubscribe:From; b=Ac7Ajx8FmxGU019No5Z1pO3wchtQ2d8WJ1HZn/ZaXIHICQb6i4J3Pk/f+DjccYNU4 RSLSYEqx2MWdBXESFdDqkxnK8O2tgpFqwGh+gM411ccdsTlEGMlZ4IAc1o3cN7EDS4 Ov+P+2wpmutb2h92zzDT11nNcmtYxkPAlggAS0Gk=
Date: Wed, 01 Jul 2020 22:21:25 -0700
From: Kazu Yamamoto <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZI27BQTZQPKSNWMI55BFH5LEVBNHHCNOGIUE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3813@github.com>
Subject: [quicwg/base-drafts] Minor fixes for the recovery draft (#3813)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5efd6ed57655c_dfd3fdfe4acd95c151863"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazu-yamamoto
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RUzGfK-kA-KgL6kW1TnRaYF4XH8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2020 05:21:28 -0000

- In A.8 `#` should be `//`.
- Both "in-flight" and "in flight" are used. It's better to uniform them to "in-flight".
- The same for "count toward" and "count towards".
- The packet field `ack_eliciting` is not referred. It should be removed.
- The packet field `sent_bytes` is defined but the field name actually used is `size`. `.size` should be `.sent_bytes`.
- In Sec 6.2.3 "For example, clients can coalesce an Initial packet containing PING and PADDING frames with a 0-RTT data packet and a server can coalesce an Initial packet containing a PING frame with one or more packets in its first flight".  Singular vs plural: client*s* and *a* server. "Clients" should be "a client".
- Should `max_datagram_size` be `max_udp_payload_size` for clarity?
- In A.6, I think that `OnDatagramReceived` should be `OnPacketReceived` since `OnPacketSent` is used in A.5.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3813