Re: [quicwg/base-drafts] Improve ACK_ECN frame encoding (e.g., use bit-vector) (#1439)
ianswett <notifications@github.com> Thu, 14 June 2018 14:11 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 726D4130DCA for <quic-issues@ietfa.amsl.com>; Thu, 14 Jun 2018 07:11:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9L_CUZBOM8ur for <quic-issues@ietfa.amsl.com>; Thu, 14 Jun 2018 07:11:54 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 23B9612777C for <quic-issues@ietf.org>; Thu, 14 Jun 2018 07:11:54 -0700 (PDT)
Date: Thu, 14 Jun 2018 07:11:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1528985513; bh=90RhRXjC6Ft9/rWQCImLoc+NBL0apRrfIkY8HbB32RU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pVLr/hGszOxJLKJxoem7lEr8CiV5qtuQsVgD7zCQ3GZnv6Aevgq5adEdD3CUnQyAd yoCHKmrBErVoycYsi/aQpoLiv9Sw1xHwd8FFiyD8x1XSsBpRZ+wwHOlGkWqZaNbhtt qtuNhKoPiOIaqoNp7OipSsfpi3pSRtHNDqL8Zk4M=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab5a962f7b75ac03511b9fe101c2e08dbb66cedd2392cf00000001173a39a992a169ce13c0caa7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1439/397310140@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1439@github.com>
References: <quicwg/base-drafts/issues/1439@github.com>
Subject: Re: [quicwg/base-drafts] Improve ACK_ECN frame encoding (e.g., use bit-vector) (#1439)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b2277a955a33_4e0f3f9fc2864f881944e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RaeGTXmiY6BQpF4ot3Vyq918Mpc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jun 2018 14:11:57 -0000
I'm going to reiterate: I don't think duplicate detection is a hard problem. You have an IntervalSet that is used to generate an ack. That goes back some distance in packet number space. At some point, you drop older/smaller blocks off that data structure. When you do, I'm suggesting you stop trying to decrypt packets with packet numbers than whatever packet number you've decided you're no longer waiting for(whether due to acks of acks or some other algorithm). There might be some cases when this InteralSet needs to be a bit larger than what you serialize to an ack frame, but that's not too difficult to deal with. The truncated packet number encoding is designed with increasing packet numbers in mind, so the only thing we're trying to allow is accepting packets within some reordering threshold. Certainly a receiver can decide to have a longer reordering threshold than an RTT, but at some point not too much longer than an RTT, it's reasonable to assume the peer retransmitted the data anyway. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/1439#issuecomment-397310140
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Martin Thomson
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- [quicwg/base-drafts] Improve ACK_ECN frame encodi… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… ianswett
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Antoine Delignat-Lavaud
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… ianswett
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Martin Thomson
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Martin Thomson
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Lars Eggert
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… MikkelFJ
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Kazuho Oku
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Magnus Westerlund
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Martin Thomson
- Re: [quicwg/base-drafts] Improve ACK_ECN frame en… Martin Thomson