Re: [quicwg/base-drafts] Minor nits (#1800)
martinduke <notifications@github.com> Wed, 26 September 2018 21:17 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 46A38130F80 for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 14:17:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OFEuNPIsVnWJ for <quic-issues@ietfa.amsl.com>; Wed, 26 Sep 2018 14:17:51 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 077B6130E41 for <quic-issues@ietf.org>; Wed, 26 Sep 2018 14:17:51 -0700 (PDT)
Date: Wed, 26 Sep 2018 14:17:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537996670; bh=ss190dzmqe8owOUA1/zIJTAwHlqT5z/F8hHZ6SVQMJ4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=rfZhJfs0IMp7vYyjJj1t7lOKqi0bnNHxdAtiCPGq6iFZJMuPtY1s+d6F4RBhalQSF BM2XVRwGzRNOZ+GyiOBN/OP3/NjOjb7hey5oDOT5vx1OpI/PimzTEw/MlLStHHI6kd qY71HRZKsy2TME85X/nGAcD0hr+d8UIUb0bmTVbc=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abadb7a6242659318eb6a59133b2cc3f1943317f3092cf0000000117c3b97d92a169ce15af9397@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1800/review/159202854@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1800@github.com>
References: <quicwg/base-drafts/pull/1800@github.com>
Subject: Re: [quicwg/base-drafts] Minor nits (#1800)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5babf77dea683_6bbf3fd520ed45c41194ae"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RajXOe-xDNU3Hi6dzGWPRHpXWmU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 21:18:00 -0000
martinduke commented on this pull request. > @@ -387,6 +392,10 @@ peer in CRYPTO frames. When TLS provides handshake octets to be sent, they are appended to the current flow and any packet that includes the CRYPTO frame is protected using keys from the corresponding encryption level. +Unlike its operations with TCP, the TLS bytestream is never separately +encrypted and decrypted. This operation only occurs on the QUIC packet as a +whole. I have spent some time looking through the quic-tls draft and cannot find it. That doesn't mean it's not there, but I'll use your language. I am really looking for a clear statement that says "turn off TLS handshake encryption, dummy". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1800#discussion_r220726879
- [quicwg/base-drafts] Minor nits (#1800) martinduke
- Re: [quicwg/base-drafts] Minor nits (#1800) martinduke
- Re: [quicwg/base-drafts] Minor nits (#1800) martinduke
- Re: [quicwg/base-drafts] Minor nits (#1800) Martin Thomson
- Re: [quicwg/base-drafts] Minor nits (#1800) martinduke
- Re: [quicwg/base-drafts] Minor nits (#1800) martinduke
- Re: [quicwg/base-drafts] Minor nits (#1800) Martin Thomson
- Re: [quicwg/base-drafts] Minor nits (#1800) Martin Thomson
- Re: [quicwg/base-drafts] Minor nits (#1800) Martin Thomson