Re: [quicwg/base-drafts] One Retry/VN per UDP datagram (#2303)
janaiyengar <notifications@github.com> Wed, 16 January 2019 00:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 98437126F72 for <quic-issues@ietfa.amsl.com>; Tue, 15 Jan 2019 16:13:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.553
X-Spam-Level:
X-Spam-Status: No, score=-12.553 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TgGkelKZre70 for <quic-issues@ietfa.amsl.com>; Tue, 15 Jan 2019 16:13:58 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 126AA126C01 for <quic-issues@ietf.org>; Tue, 15 Jan 2019 16:13:58 -0800 (PST)
Date: Tue, 15 Jan 2019 16:13:56 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1547597636; bh=1ko062Dz7qSGCRB8CYRKhsI+M9UuO4swSOCD3jn8Tk8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=t7APnjI0bjT/pzQBJ/PluXX3xSLQYwn9QVr3NwITj6dC/rG1ftgM/+b8+sNmXu1jy gwLJSP/5sJLw80FwV2SYsQvZfv/kObcPUQlUOtl2QV3Zs1zAip4yMswVzXf5oTf1ik TVO2NPKFxa+3oFnqoR+zyj8GhsHOwUjxPj8OqfS8=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb7d960b1e87a4f3b397c0ffd7d3bb8ee3f922b0e92cf000000011856394492a169ce179f536f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2303/c454601267@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2303@github.com>
References: <quicwg/base-drafts/pull/2303@github.com>
Subject: Re: [quicwg/base-drafts] One Retry/VN per UDP datagram (#2303)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c3e7744d41d7_62cb3ff4d40d45b8113540"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Rb-p9LVetKM5RdiFZimPVlJl-hI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Jan 2019 00:14:00 -0000
I think this PR addresses the amplification problem directly, by tying the number of response datagrams to the number of incoming datagrams, so I am in favor of this PR as a spec solution. @marten-seemann : quic-go can still choose to drop datagrams with a large (> 3?) coalesced packets, which might help you (slightly). I agree with @kazuho also that since all coalesced packets are supposed to go to the same connection, the implementation would be better aligned if it were to pass the datagram along to the connection instead of the individual packets... but that's an impl choice, and it's certainly not the only way to do this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2303#issuecomment-454601267
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Kazuho Oku
- [quicwg/base-drafts] One Retry/VN per UDP datagra… Martin Thomson
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Kazuho Oku
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Marten Seemann
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Martin Thomson
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Marten Seemann
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Kazuho Oku
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Marten Seemann
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Kazuho Oku
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… ianswett
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… Marten Seemann
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… janaiyengar
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… janaiyengar
- Re: [quicwg/base-drafts] One Retry/VN per UDP dat… janaiyengar