IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)

ianswett <notifications@github.com> Sun, 18 March 2018 09:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 538D3127241 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:25:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.606
X-Spam-Level:
X-Spam-Status: No, score=-5.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HNN3qlyORj34 for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 02:25:00 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 237611200FC for <quic-issues@ietf.org>; Sun, 18 Mar 2018 02:25:00 -0700 (PDT)
Date: Sun, 18 Mar 2018 02:24:59 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521365099; bh=0LBSWQ+5p/F93CTGgrJut7XXB2JVAOdzMKJnq+FWCW0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=p/Cedvc5V4qsHRMoZKEG6A6eJUTyYZca4yjwulhRbTNrtMs8b62MIIHmOxW84sU7W Tixy2JCDRcbA9oMGsSKwPf3CVHgGijdZll8ZxEexytRqTFJ074Y457iLDJ7ub6kw2Z Fl/jjcXNtUPLVIej14LR9zFrqKRImNPFZocMFbKA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab06e9d6c90ba3fec52c3e00a1eaefe6a4d4e116a492cf0000000116c5f26b92a169ce123fc47f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1223/review/104790758@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1223@github.com>
References: <quicwg/base-drafts/pull/1223@github.com>
Subject: Re: [quicwg/base-drafts] don't apply congestion penalty for lost ack-only packets (#1223)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae306b304f5_2875b3f9698238f3414787"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Rcgg_Cy9XfUpvgkp4HVoeuwhCyM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 09:25:01 -0000

ianswett commented on this pull request.



> @@ -834,19 +834,18 @@ DetectLostPackets(largest_acked):
   foreach (unacked < largest_acked.packet_number):
     time_since_sent = now() - unacked.time_sent
     delta = largest_acked.packet_number - unacked.packet_number
-    if (time_since_sent > delay_until_lost):
-      lost_packets.insert(unacked)
-    else if (delta > reordering_threshold)
-      lost_packets.insert(unacked)
+    if (time_since_sent > delay_until_lost ||
+      delta > reordering_threshold):

I think the d needs to line up with the 't' of time_since_sent based on looking at OnPacketAcked.

The current indention is confusing, since the delta > reordering_threshold blends into the code that follows.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1223#pullrequestreview-104790758

v2.27.8 | Report a Bug | By Email | System Status