Date: Sat, 01 Dec 2018 23:12:51 -0800
From: Christian Huitema <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abf45ef25502feacdcad5da5f2f0fec3995a159de892cf00000001181b47f392a169ce17097d1f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2089/review/180550132@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2089@github.com>
References: <quicwg/base-drafts/pull/2089@github.com>
Subject: Re: [quicwg/base-drafts] Repeat tokens in all Initial packets (#2089)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c0385f3b50b9_15d13fa2fded45c43853de";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/RmxDikiUEIgh9BKUUELn5dekShI>


----==_mimepart_5c0385f3b50b9_15d13fa2fded45c43853de
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

huitema commented on this pull request.



> @@ -1590,9 +1588,11 @@ amount of data to a client in response to 0-RTT data.
 
 The server uses the NEW_TOKEN frame {{frame-new-token}} to provide the client
 with an address validation token that can be used to validate future
-connections.  The client may then use this token to validate future connections
-by including it in the Initial packet's header.  The client MUST NOT use the
-token provided in a Retry for future connections.
+connections.  The client includes this token in Initial packets to provide
+address validation in a future connection.  The client MUST include the
+token in all Initial packets it sends, unless a Retry replaces the token
+with a newer token. The client MUST NOT use the token provided in a Retry
+for future connections.
 

Yes, discard is fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301
----==_mimepart_5c0385f3b50b9_15d13fa2fded45c43853de
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@huitema</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1590,9 +1588,11 @@ amount of data to a client in response to 0-RTT data.
 
 The server uses the NEW_TOKEN frame {{frame-new-token}} to provide the client
 with an address validation token that can be used to validate future
-connections.  The client may then use this token to validate future connections
-by including it in the Initial packet&#39;s header.  The client MUST NOT use the
-token provided in a Retry for future connections.
+connections.  The client includes this token in Initial packets to provide
+address validation in a future connection.  The client MUST include the
+token in all Initial packets it sends, unless a Retry replaces the token
+with a newer token. The client MUST NOT use the token provided in a Retry
+for future connections.
 
</pre>
<p>Yes, discard is fine.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq2WSEEIklw7ECaLQHLvYZI0Ep4UMks5u031zgaJpZM4Y9GLX">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq0Seme0orOUE-HLsNjUNclu0YnnAks5u031zgaJpZM4Y9GLX.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@huitema commented on #2089"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301",
"url": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@huitema commented on 2089",
"sections": [
{
"text": "",
"activityTitle": "**Christian Huitema**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@huitema",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238087301"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418669271\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5c0385f3b50b9_15d13fa2fded45c43853de--