Date: Mon, 20 Jan 2020 01:15:00 -0800
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZXQ6CVJ4WOJ3CRRP54GKRBJEVBNHHCBWRIJQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3354/review/345164970@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3354@github.com>
References: <quicwg/base-drafts/pull/3354@github.com>
Subject: Re: [quicwg/base-drafts] Better describe the use of Preferred Address
 (#3354)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e256f944decf_7a693ffba38cd9605933ac";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S1WABC8NSzLEJTE-9sfm1ZYuTAE>


----==_mimepart_5e256f944decf_7a693ffba38cd9605933ac
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

kazuho commented on this pull request.



>  
 If path validation succeeds, the client SHOULD immediately begin sending all
-future packets to the new server address using the new connection ID and
-discontinue use of the old server address.  If path validation fails, the client
-MUST continue sending all future packets to the server's original IP address.
-
+future packets to the new server and discontinue use of the old server address,
+and retire the connection ID that was used for the original path
+({{retiring-cids}}).  If path validation fails, or if the client decides not to
+migrate to the preferred address, it MUST continue sending all future packets to
+the server's original IP address, and retire the connection ID provided by the
+preferred_address transport parameter.  Retirement of either of these connection
+IDs notifies the server of the address the client has chosen.

Maybe you want to state that in the issue (i.e. #3353), as we've been discussing there about having this requirement?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3354#discussion_r368436587
----==_mimepart_5e256f944decf_7a693ffba38cd9605933ac
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@kazuho</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3354#discussion_r368436587">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  
 If path validation succeeds, the client SHOULD immediately begin sending all
-future packets to the new server address using the new connection ID and
-discontinue use of the old server address.  If path validation fails, the client
-MUST continue sending all future packets to the server&#39;s original IP address.
-
+future packets to the new server and discontinue use of the old server address,
+and retire the connection ID that was used for the original path
+({{retiring-cids}}).  If path validation fails, or if the client decides not to
+migrate to the preferred address, it MUST continue sending all future packets to
+the server&#39;s original IP address, and retire the connection ID provided by the
+preferred_address transport parameter.  Retirement of either of these connection
+IDs notifies the server of the address the client has chosen.
</pre>
<p>Maybe you want to state that in the issue (i.e. <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="551074329" data-permission-text="Issue title is private" data-url="https://github.com/quicwg/base-drafts/issues/3353" data-hovercard-type="issue" data-hovercard-url="/quicwg/base-drafts/issues/3353/hovercard" href="https://github.com/quicwg/base-drafts/issues/3353">#3353</a>), as we've been discussing there about having this requirement?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications&amp;email_token=AFTOJKZ2GOZ6CKIFBGBVMGDQ6VTRJA5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJMZKQ#discussion_r368436587">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK37RFKUFLSSJ6MIXI3Q6VTRJANCNFSM4KIBEVSQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2YHUN3DLSBBQSYZ5TQ6VTRJA5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJMZKQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications\u0026email_token=AFTOJKZ2GOZ6CKIFBGBVMGDQ6VTRJA5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJMZKQ#discussion_r368436587",
"url": "https://github.com/quicwg/base-drafts/pull/3354?email_source=notifications\u0026email_token=AFTOJKZ2GOZ6CKIFBGBVMGDQ6VTRJA5CNFSM4KIBEVS2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSJMZKQ#discussion_r368436587",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e256f944decf_7a693ffba38cd9605933ac--