Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)

Martin Thomson <notifications@github.com> Wed, 06 February 2019 04:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ED6BF1288BD for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 20:50:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -12.552
X-Spam-Level:
X-Spam-Status: No, score=-12.552 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KqW_rJrvW_lR for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 20:50:07 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 59A4112426E for <quic-issues@ietf.org>; Tue, 5 Feb 2019 20:50:07 -0800 (PST)
Date: Tue, 05 Feb 2019 20:50:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549428606; bh=UK3Tx0RmnAwY8rvMNYtRMoRoJ0QBVdaRIms2t7wbGCA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MonzavFIBvZkM7S/Cg3usUZm8PvMVaauJDPhvmlJlGBnjahCJ54/BBiMEnOrN/eeb OVZmp6b2LmpPTWfUc7f5z5p1HO9ijf3ncPhjH5qm17m0gc8NYchrOjD7wqqPEneuCu b06swqMLtXLZWKMgGwjVtShzhGQsyLLo64UXpTFE=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abbccd1a6bb2d9ce2c7cb3767e06b82dc9b22c606a92cf000000011872297e92a169ce1842c3b7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2424/review/200412061@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2424@github.com>
References: <quicwg/base-drafts/pull/2424@github.com>
Subject: Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a677e4275d_47583fd238cd45c021949a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S1p7vg1i_R9cSOxhv_4JfhayUo0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 04:50:09 -0000

martinthomson commented on this pull request.



> @@ -244,11 +249,9 @@ ack-eliciting packet. QUIC recovery algorithms do not assume the peer sends
 an ACK immediately when receiving a second ack-eliciting packet.
 
 In order to accelerate loss recovery and reduce timeouts, the receiver SHOULD
-send an immediate ACK when it receives a new packet which is not one greater
-than the largest received packet number. A receiver MAY send immediate ACKs
-for the next few ack-eliciting packets that are received, but SHOULD NOT
-send an immediate ACK for more than 1/8 RTT after receiving an out-of-order
-packet.
+send immediate ACKs for an interval after it receives an out-of-order packet.

So I'm still not clear.  If I get a continuous stream of reordered packets, a) when do I cease immediate ACKs, and b) if I do stop immediate ACKs, when can I start again?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2424#discussion_r254137269