Re: [quicwg/base-drafts] QPACK: Updated Static Table (#1355)

Mark Nottingham <notifications@github.com> Tue, 18 September 2018 16:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 06E74130E14 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 09:14:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xRPlUZIGPDTc for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 09:14:25 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 74F67130DE9 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 09:14:25 -0700 (PDT)
Date: Tue, 18 Sep 2018 09:14:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1537287264; bh=KXrBDJmQT+9ovyhWClixnakSg3BrR9rxHxHokX/H/jw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OiNbPB3Y1mgVus7JTjg9k5qXsiLApx3+75aqlv6JqamoN7GUWxriJ+AnAd8E6rBA3 XHPmwIDhMKVHfFOxlbOWZWhNBkljsTfyHU6Uqo8fFMwKAyioZ/gb73wQPT3VyMvdAT PRx8C5vBJcHG3wKhxXdfgIKGlUTgJ/wBukmsJzyk=
From: Mark Nottingham <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7caee4e9124a55a920c7393deeab421c2d519fc292cf0000000117b8e66092a169ce13459be3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1355/review/156448586@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1355@github.com>
References: <quicwg/base-drafts/pull/1355@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Updated Static Table (#1355)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba124606dcf0_1efb3fedff2d45c493041d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mnot
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S2JRwVSvKJlgK3035QyUN8h4H1Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 16:14:27 -0000

mnot commented on this pull request.



> +| 59    | user-agent                       |                                                       |
+| 60    | vary                             | accept-encoding                                       |
+| 61    | vary                             | accept-encoding, user-agent                           |
+| 62    | vary                             | origin                                                |
+| 63    | :status                          | 100                                                   |
+| 64    | :status                          | 103                                                   |
+| 65    | :status                          | 204                                                   |
+| 66    | :status                          | 206                                                   |
+| 67    | :status                          | 302                                                   |
+| 68    | :status                          | 400                                                   |
+| 69    | :status                          | 403                                                   |
+| 70    | :status                          | 404                                                   |
+| 71    | :status                          | 421                                                   |
+| 72    | :status                          | 425                                                   |
+| 73    | :status                          | 500                                                   |
+| 74    | :status                          | 503                                                   |

Are putting three-character status codes in the static table really necessary?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1355#pullrequestreview-156448586