Re: [quicwg/base-drafts] Length-prefixes and flow control (#1432)

Ryan Hamilton <notifications@github.com> Fri, 03 August 2018 14:19 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6809B131010 for <quic-issues@ietfa.amsl.com>; Fri, 3 Aug 2018 07:19:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ppzENcae0_du for <quic-issues@ietfa.amsl.com>; Fri, 3 Aug 2018 07:19:30 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9A742130EF9 for <quic-issues@ietf.org>; Fri, 3 Aug 2018 07:19:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=4mA6ggKRKSfy25IFvWI4/iqaNcc=; b=TjLgWYSiyUJu6s7v aTBd+QyNPmZ81G/lEWVEBy0ndvUubz6T2JwCIGxq+hmmad+w1ak+m59sUksMfpjZ AohFgF4/tT6GHGOM90qh02W4oDedH80FlLxGdtrErw+Os1+CmioPhxFUlY2ZV1L3 H4UuEndG070InkKY5kDYaWSq3kY=
Received: by filter1503p1mdw1.sendgrid.net with SMTP id filter1503p1mdw1-15408-5B646471-1B 2018-08-03 14:19:29.593066303 +0000 UTC m=+749068.516437899
Received: from github-lowworker-5909e27.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0004p1iad2.sendgrid.net (SG) with ESMTP id whKZCZQMSMaPYmuXLZsZtQ for <quic-issues@ietf.org>; Fri, 03 Aug 2018 14:19:29.508 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-5909e27.cp1-iad.github.net (Postfix) with ESMTP id 8D4523E14E6 for <quic-issues@ietf.org>; Fri, 3 Aug 2018 07:19:29 -0700 (PDT)
Date: Fri, 03 Aug 2018 14:19:29 +0000
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab67c629e1adfb83386a7fd2f239c905bbb6d5137a92cf00000001177c267192a169ce13b52edd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1432/410264806@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1432@github.com>
References: <quicwg/base-drafts/issues/1432@github.com>
Subject: Re: [quicwg/base-drafts] Length-prefixes and flow control (#1432)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6464718bee3_212b3f8213cd45b881336"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2DqZb3pxweXpfj1c4tKT4ccgO17gkwMePrVc MZ5SqLjDUhl4/wjPNHAJm8kkzK+X+I1mWhG6yXKmVLoJeb9o0+ISJWPLq9RrJHh4QSsAzk+u0NMB+7 oH+bHBLdz9oLVvli4Kzuv5Z7ykcrHTOfEd3njLGDz8aGRBcb6QGVa/xJ6QixzDDKJiympeGLHhMpjl Y=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S6ZQuOmc3qN6TWEQDM4HlEjnHsY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Aug 2018 14:19:33 -0000

It seems like the general advice should be something along the lines of, "applications should not use a stream's receive buffer to store data while they wait for more data to arrive, as this can potentially lead to deadlock. instead they should read data out of the buffers expeditiously."

Really receive buffers should only be used to store data when the application is temporarily blocked from processing data and should be read as soon as the application is unblocked. What do you think?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1432#issuecomment-410264806